Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Improve SSO auth flow #5578

Merged
merged 8 commits into from
Jan 29, 2021
Merged

Improve SSO auth flow #5578

merged 8 commits into from
Jan 29, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 27, 2021

Requires element-hq/element-web#16292
Fixes element-hq/element-web#16219

  • Use replaceState instead of a redirect to strip the loginToken
  • Put user into the same post-auth flows of E2ESetup
  • Skip UIA prompt in this post-auth flow, happy path is a server grace period
  • Respect SSO IdP brand styling
  • Improve SSO UIA flow by:
    • auto-closing the tab
    • better error on failure

Reviewing commit-by-commit is recommended.

image

Use replaceState instead of a redirect to strip the loginToken
Put user into the same post-auth flows of E2ESetup
Skip UIA prompt in this post-auth flow, happy path is a server grace period
For better brand adherance.
Also removes old support for https IdP icons.
Fixes Fallback UIA postmessage interface
Auto-closes SSO UIA tab when the user has completed the flow within it
Error for when auth stage is restarted because it failed
@t3chguy t3chguy marked this pull request as ready for review January 28, 2021 10:46
@t3chguy t3chguy requested a review from a team January 28, 2021 10:46
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like a great improvement! 😄

@@ -0,0 +1,3 @@
<svg width="25" height="24" viewBox="0 0 25 24" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Off-topic) I'm not really sure why we have an element-icons directory at all... But anyway, it's been around for a while.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was for when the rebrand replaced a bunch but not all of the icons

src/components/structures/InteractiveAuth.js Outdated Show resolved Hide resolved
@t3chguy t3chguy requested a review from jryans January 29, 2021 13:05
@t3chguy t3chguy added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Jan 29, 2021
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if ready!

@@ -64,11 +78,6 @@ limitations under the License.
border-color: #3c5a99;
color: #ffffff;
}
.mx_SSOButton.mx_SSOButton_brand_google {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no colours needed for Google now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the branding guidelines show it as a colourful logo on a white button. The old figma for it was white logo on red button but thats Google+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@t3chguy t3chguy merged commit 6271215 into develop Jan 29, 2021
@t3chguy t3chguy deleted the t3chguy/sso_fixes branch January 29, 2021 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UIA-over-SSO leaves you marooned in a "please close this tab" tab
2 participants