This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Improve SSO login start screen and 3pid invite handling somewhat #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
Feb 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the rework ( #5578 ) of how SSO login bootstrapped the app, an edge case was created where
onLoggedInwould get called twice due to the app loading in an unexpected cycle which caused the first screen to get discarded on a subsequent internal redirect.Also tries to match up known 3PID invites when viewing rooms so that if someone refreshes a 3PID invite it doesn't vanish.