This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
forceDestroy when resetting a widget
#8045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
github-actions
bot
added
the
T-Defect
Codecov Report
@@ Coverage Diff @@
## develop #8045 +/- ##
========================================
Coverage 26.79% 26.79%
========================================
Files 865 865
Lines 51974 51974
Branches 13168 13168
========================================
Hits 13926 13926
Misses 38048 38048
|
|
While this does solve the freezing issue, I'm still seeing other weird behavior from the 2 Jitsi widgets I'm testing with, and I think the root cause of all this is that those widgets actually have the same widget ID, which is causing the app to get the persisted iframes confused. I would recommend we go with #8049 instead, which doesn't require |
|
I haven't tested #8049 but if you say it fixes the issue it feels better than this solution 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21399
Type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes
forceDestroywhen resetting a widget (#8045). Fixes App freezes when switching between two rooms with Jitsi widgets element-hq/element-web#21399. Contributed by @SimonBrandner.Preview: https://pr8045--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.