This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Ensure that widget PersistedElement IDs are unique between rooms #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Townsend <robin@robin.town>
github-actions
bot
added
the
T-Defect
Codecov Report
@@ Coverage Diff @@
## develop #8049 +/- ##
========================================
Coverage 26.79% 26.79%
========================================
Files 865 865
Lines 51974 51976 +2
Branches 13168 13170 +2
========================================
+ Hits 13926 13927 +1
- Misses 38048 38049 +1
|
|
I'm going to follow this up tomorrow with a PR that fixes this faulty assumption in more places throughout the app, since there's actually a lot more code that assumes widget IDs are globally unique. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: defect
Closes element-hq/element-web#21399.
Here's what your changelog entry will look like:
🐛 Bug Fixes
Preview: https://pr8049--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.