chore(cargo): Update ruma
#4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
chore-update-ruma
branch
3 times, most recently
from
8ea2fa7
to
2f807ee
Compare
poljar
approved these changes
Sep 27, 2024
|
Haha, eh, just a little something while getting bored. |
Hywan
force-pushed
the
chore-update-ruma
branch
3 times, most recently
from
dfd8d46
to
95ea8e8
Compare
This patch changes the behaviour of `timeline_limit` in sliding sync requests. It previously was sticky, but since it's now mandatory with MSC4186, it's preferable it to be non-sticky, otherwise in some scenarios it might default to 0 (its default value). How? If the server doesn't reply with our `txn_id` (because it doesn't support sticky parameters or because it misses a `txn_id`), the next request will be built with a default `timeline_limit` value, which is zero, and won't get updated to the `timeline_limit` value from `SlidingSyncListStickyParameters`. This is not good. Instead, we must consider `timeline_limit` as non-sticky, and moves it from `SlidingSyncListStickyParameters` to `SlidingSyncListInner`. This is what this patch does.
Hywan
force-pushed
the
chore-update-ruma
branch
from
95ea8e8
to
9807357
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4039 +/- ##
==========================================
+ Coverage 84.66% 84.67% +0.01%
==========================================
Files 269 269
Lines 28715 28711 -4
==========================================
Hits 24311 24311
+ Misses 4404 4400 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
rumato include:sync::v5::Response::initialruma/ruma#1913sync::v5::Request::timeline_limitis not optional ruma/ruma#1914