Media: Add support for media captions. #4081
Conversation
bindings/matrix-sdk-ffi/src/ruma.rs
Outdated
| event_content.filename = content.filename; | ||
| event_content.filename = Some(content.filename); |
There was a problem hiding this comment.
I'm not 100% about these first 4 mappings going back to Ruma. Is it important to store the non-computed filename in the FFI type so that we can pass that back here, or is that an unnecessary step?
There was a problem hiding this comment.
I think this is technically only used for edits and media events can't have them AFAICT, so it might not be needed. However, I don't see the harm in passing it around in case we might need it in the future.
There was a problem hiding this comment.
I've added it back as raw_filename.
pixlwave
force-pushed
the
doug/media-captions
branch
3 times, most recently
from
633d9b1
to
0c01fec
Compare
bindings/matrix-sdk-ffi/src/ruma.rs
Outdated
| event_content.filename = content.filename; | ||
| event_content.filename = Some(content.filename); |
There was a problem hiding this comment.
I think this is technically only used for edits and media events can't have them AFAICT, so it might not be needed. However, I don't see the harm in passing it around in case we might need it in the future.
|
The tests need some love though 😅 . |
pixlwave
force-pushed
the
doug/media-captions
branch
2 times, most recently
from
787a049
to
5519dae
Compare
|
Just updated adding in the |
Also includes the computed filename too.
pixlwave
force-pushed
the
doug/media-captions
branch
from
5519dae
to
204c45e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4081 +/- ##
==========================================
+ Coverage 84.66% 84.67% +0.01%
==========================================
Files 269 269
Lines 28694 28694
==========================================
+ Hits 24294 24297 +3
+ Misses 4400 4397 -3 ☔ View full report in Codecov by Sentry. |
| @@ -537,6 +543,7 @@ async fn test_sync_resumes_from_previous_state() -> Result<(), Error> { | |||
| "lists": { | |||
| ALL_ROOMS: { | |||
| "ranges": [[0, 9]], | |||
| "timeline_limit": 0, | |||
There was a problem hiding this comment.
All these timeline_limit to 0 is a bug, fixed in #4039 :-).
There was a problem hiding this comment.
Ooops, I thought it was mocks not being fully fleshed out 🙈
This PR makes 2 changes: