MSC3289: Room version 8 #3289

clokep · 2021-07-21T12:14:12Z

For links, here's the MSCs included:

MSC3083 - Restricting room membership based on membership in other rooms

For reference there was matrix-org/matrix-spec#794 filed, but it seems like most of those don't have implementations.

Implementation: matrix-org/synapse#10449

ara4n · 2021-07-21T12:52:33Z

it's a nobrainer, and by having 8 build directly on 7 (rather than 7 being only-knocking, 8 being only-restricted, and 9 being both) we avoid the painful choreography of having some rooms which are knocking-but-not-restricted and some which are restricted-but-not-knocking and having to expose that intelligently in clients.

ara4n · 2021-07-21T12:53:07Z

@mscbot fcp merge

mscbot · 2021-07-21T12:53:09Z

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

~~test version first~~

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

anoadragon453

The proposal looks good to me otherwise.

proposals/3289-rooms-v8.md

richvdh · 2021-07-21T13:31:40Z

@mscbot concern test version first

Please can we first have an implementation of test room version which matches the expected behaviour (ie, knocking, plus MSC3083)?

proposals/3289-rooms-v8.md

richvdh · 2021-07-27T16:13:28Z

proposals/3289-rooms-v8.md

@@ -0,0 +1,22 @@
+# MSC3289: Room Version 8
+
+A new room version, `8`, is proposed using [room version 7](https://spec.matrix.org/unstable/rooms/v7/)


I've been thinking about what I would expect to see before I'm happy to resolve my concern about the lack of an implementation.

Implementation: matrix-org/synapse@ccdcc7f

This is noted, and thanks, but I'd like to see the following:

a Synapse has been deployed with a test room version exactly matching the proposed parameters and that people have actually sent messages through it and they have been correctly received. In particular my understanding is that substantial parts of MSC3083 haven't yet been tested outside a development environment.

Given our recent discovery of the problem with redactions, I think some manual testing that auth still works when various bits of the room state are redacted would be wise.

I'd like to know that somebody has tested the test room version with Sytest's --room-version (and Complement's equivalent, if there is one).

I'd like to know that somebody has tested the test room version with Sytest's --room-version (and Complement's equivalent, if there is one).

Thia has been done, but needs matrix-org/sytest#1100 so that the fake server knows about the room version.

For the record, I was somewhat expecting the sytesting to happen against org.matrix.msc3083.v2 (or whatever) to save having to wait for this MSC to complete. But I realise that means more sytest PRs, and your approach of using a sytest branch is equally valid.

@clokep: how are the other two bullet points looking?

Given our recent discovery of the problem with redactions, I think some manual testing that auth still works when various bits of the room state are redacted would be wise.

I tested this manually again by:

Creating a test room set to join via a space.

Ensuring that I could join the space, then room.

Ensuring that joining the room first does not work.

Ensuring that invites work.

I then redacted the m.room.join_rules event.

I then repeated tests 2 - 4 with new users and ensured the checks were still enforced by the server.

Does that sound sufficient or have I missed something?

a Synapse has been deployed with a test room version exactly matching the proposed parameters and that people have actually sent messages through it and they have been correctly received. In particular my understanding is that substantial parts of MSC3083 haven't yet been tested outside a development environment.

matrix.org now supports the org.matrix.msc3083.v2 room and I have created a test room which is joinable via membership in #community:matrix.org. This is not quite "exactly matching the proposed parameters" however as org.matrix.msc3083.v2 is based on room version 6, not room version 7 (it doesn't support knocking).

it sounds grand to me.

This reverts commit 203c107.

richvdh · 2021-08-03T13:30:13Z

@mscbot resolve test version first

mscbot · 2021-08-08T13:30:27Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\matrix-org#10449](matrix-org#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\matrix-org#10449](matrix-org#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\matrix-org#10543](matrix-org#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\matrix-org#10517](matrix-org#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\matrix-org#10531](matrix-org#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\matrix-org#10516](matrix-org#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\matrix-org#9918](matrix-org#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\matrix-org#10245](matrix-org#10245), [\matrix-org#10432](matrix-org#10432), [\matrix-org#10463](matrix-org#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\matrix-org#10254](matrix-org#10254), [\matrix-org#10447](matrix-org#10447), [\matrix-org#10489](matrix-org#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\matrix-org#10283](matrix-org#10283)) - Add a buffered logging handler which periodically flushes itself. ([\matrix-org#10407](matrix-org#10407), [\matrix-org#10515](matrix-org#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\matrix-org#10411](matrix-org#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\matrix-org#10413](matrix-org#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\matrix-org#10426](matrix-org#10426)) - Allow setting transaction limit for database connections. ([\matrix-org#10440](matrix-org#10440), [\matrix-org#10511](matrix-org#10511)) - Add `creation_ts` to "list users" admin API. ([\matrix-org#10448](matrix-org#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\matrix-org#10410](matrix-org#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\matrix-org#10439](matrix-org#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\matrix-org#10455](matrix-org#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\matrix-org#10499](matrix-org#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\matrix-org#10445](matrix-org#10445)) - Consolidate development documentation to `docs/development/`. ([\matrix-org#10453](matrix-org#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\matrix-org#10464](matrix-org#10464)) - Document how to use Complement while developing a new Synapse feature. ([\matrix-org#10483](matrix-org#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\matrix-org#10390](matrix-org#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\matrix-org#10408](matrix-org#10408)) - Remove shebang line from module files. ([\matrix-org#10415](matrix-org#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\matrix-org#10429](matrix-org#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\matrix-org#10431](matrix-org#10431)) - Improve servlet type hints. ([\matrix-org#10437](matrix-org#10437), [\matrix-org#10438](matrix-org#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\matrix-org#10442](matrix-org#10442)) - Update the `tests-done` Github Actions status. ([\matrix-org#10444](matrix-org#10444), [\matrix-org#10512](matrix-org#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\matrix-org#10446](matrix-org#10446), [\matrix-org#10450](matrix-org#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\matrix-org#10451](matrix-org#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\matrix-org#10468](matrix-org#10468)) - Additional type hints in the state handler. ([\matrix-org#10482](matrix-org#10482)) - Update syntax used to run complement tests. ([\matrix-org#10488](matrix-org#10488)) - Fix up type annotations to work with Twisted 21.7. ([\matrix-org#10490](matrix-org#10490)) - Improve type annotations for `ObservableDeferred`. ([\matrix-org#10491](matrix-org#10491)) - Extend release script to also tag and create GitHub releases. ([\matrix-org#10496](matrix-org#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\matrix-org#10500](matrix-org#10500))

MSC3289: Room version 8

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\#10449](matrix-org/synapse#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\#10449](matrix-org/synapse#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\#10543](matrix-org/synapse#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\#10517](matrix-org/synapse#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\#10531](matrix-org/synapse#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\#10516](matrix-org/synapse#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\#9918](matrix-org/synapse#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\#10245](matrix-org/synapse#10245), [\#10432](matrix-org/synapse#10432), [\#10463](matrix-org/synapse#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\#10254](matrix-org/synapse#10254), [\#10447](matrix-org/synapse#10447), [\#10489](matrix-org/synapse#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\#10283](matrix-org/synapse#10283)) - Add a buffered logging handler which periodically flushes itself. ([\#10407](matrix-org/synapse#10407), [\#10515](matrix-org/synapse#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\#10411](matrix-org/synapse#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\#10413](matrix-org/synapse#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\#10426](matrix-org/synapse#10426)) - Allow setting transaction limit for database connections. ([\#10440](matrix-org/synapse#10440), [\#10511](matrix-org/synapse#10511)) - Add `creation_ts` to "list users" admin API. ([\#10448](matrix-org/synapse#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\#10410](matrix-org/synapse#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\#10439](matrix-org/synapse#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\#10455](matrix-org/synapse#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\#10499](matrix-org/synapse#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\#10445](matrix-org/synapse#10445)) - Consolidate development documentation to `docs/development/`. ([\#10453](matrix-org/synapse#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\#10464](matrix-org/synapse#10464)) - Document how to use Complement while developing a new Synapse feature. ([\#10483](matrix-org/synapse#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\#10390](matrix-org/synapse#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\#10408](matrix-org/synapse#10408)) - Remove shebang line from module files. ([\#10415](matrix-org/synapse#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\#10429](matrix-org/synapse#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\#10431](matrix-org/synapse#10431)) - Improve servlet type hints. ([\#10437](matrix-org/synapse#10437), [\#10438](matrix-org/synapse#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\#10442](matrix-org/synapse#10442)) - Update the `tests-done` Github Actions status. ([\#10444](matrix-org/synapse#10444), [\#10512](matrix-org/synapse#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\#10446](matrix-org/synapse#10446), [\#10450](matrix-org/synapse#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\#10451](matrix-org/synapse#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\#10468](matrix-org/synapse#10468)) - Additional type hints in the state handler. ([\#10482](matrix-org/synapse#10482)) - Update syntax used to run complement tests. ([\#10488](matrix-org/synapse#10488)) - Fix up type annotations to work with Twisted 21.7. ([\#10490](matrix-org/synapse#10490)) - Improve type annotations for `ObservableDeferred`. ([\#10491](matrix-org/synapse#10491)) - Extend release script to also tag and create GitHub releases. ([\#10496](matrix-org/synapse#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\#10500](matrix-org/synapse#10500))

MSCs: * #3083 * #3289 * #3375

turt2live · 2021-09-08T05:14:36Z

Spec PR: #3387

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\matrix-org#10449](matrix-org#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\matrix-org#10449](matrix-org#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\matrix-org#10543](matrix-org#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\matrix-org#10517](matrix-org#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\matrix-org#10531](matrix-org#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\matrix-org#10516](matrix-org#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\matrix-org#9918](matrix-org#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\matrix-org#10245](matrix-org#10245), [\matrix-org#10432](matrix-org#10432), [\matrix-org#10463](matrix-org#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\matrix-org#10254](matrix-org#10254), [\matrix-org#10447](matrix-org#10447), [\matrix-org#10489](matrix-org#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\matrix-org#10283](matrix-org#10283)) - Add a buffered logging handler which periodically flushes itself. ([\matrix-org#10407](matrix-org#10407), [\matrix-org#10515](matrix-org#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\matrix-org#10411](matrix-org#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\matrix-org#10413](matrix-org#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\matrix-org#10426](matrix-org#10426)) - Allow setting transaction limit for database connections. ([\matrix-org#10440](matrix-org#10440), [\matrix-org#10511](matrix-org#10511)) - Add `creation_ts` to "list users" admin API. ([\matrix-org#10448](matrix-org#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\matrix-org#10410](matrix-org#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\matrix-org#10439](matrix-org#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\matrix-org#10455](matrix-org#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\matrix-org#10499](matrix-org#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\matrix-org#10445](matrix-org#10445)) - Consolidate development documentation to `docs/development/`. ([\matrix-org#10453](matrix-org#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\matrix-org#10464](matrix-org#10464)) - Document how to use Complement while developing a new Synapse feature. ([\matrix-org#10483](matrix-org#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\matrix-org#10390](matrix-org#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\matrix-org#10408](matrix-org#10408)) - Remove shebang line from module files. ([\matrix-org#10415](matrix-org#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\matrix-org#10429](matrix-org#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\matrix-org#10431](matrix-org#10431)) - Improve servlet type hints. ([\matrix-org#10437](matrix-org#10437), [\matrix-org#10438](matrix-org#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\matrix-org#10442](matrix-org#10442)) - Update the `tests-done` Github Actions status. ([\matrix-org#10444](matrix-org#10444), [\matrix-org#10512](matrix-org#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\matrix-org#10446](matrix-org#10446), [\matrix-org#10450](matrix-org#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\matrix-org#10451](matrix-org#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\matrix-org#10468](matrix-org#10468)) - Additional type hints in the state handler. ([\matrix-org#10482](matrix-org#10482)) - Update syntax used to run complement tests. ([\matrix-org#10488](matrix-org#10488)) - Fix up type annotations to work with Twisted 21.7. ([\matrix-org#10490](matrix-org#10490)) - Improve type annotations for `ObservableDeferred`. ([\matrix-org#10491](matrix-org#10491)) - Extend release script to also tag and create GitHub releases. ([\matrix-org#10496](matrix-org#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\matrix-org#10500](matrix-org#10500))

* Room versions 8 and 9: Restricted rooms MSCs: * #3083 * #3289 * #3375 * Changelogs * Capitalization Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Remove verbiage for spaces because they don't exist * Iterations on text * Another clarification * Make error code descriptions consistent * Apply suggestions from code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Incorporate from merge * Misc language update per review * Update accuracy before splitting auth rules * fix wtf moment * Fix up v8 and v9 to match "fully specify room versions" * Scope auth events selection to room version * Apply consistency * Add changelogs * Review part 1 * Apply suggestions from code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Split out redaction sections * Clarify general case of join conditions Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

turt2live · 2022-01-18T16:56:30Z

Merged 🎉

clokep and others added 2 commits July 21, 2021 08:12

Add proposal for room version 8.

806d6fc

Update 3289-rooms-v8.md

2a92acc

ara4n added the proposal A matrix spec change proposal label Jul 21, 2021

mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 21, 2021

anoadragon453 reviewed Jul 21, 2021

View reviewed changes

proposals/3289-rooms-v8.md Show resolved Hide resolved

proposals/3289-rooms-v8.md Show resolved Hide resolved

turt2live self-requested a review July 21, 2021 13:30

mscbot added the unresolved-concerns This proposal has at least one outstanding concern label Jul 21, 2021

turt2live removed their request for review July 21, 2021 16:06

turt2live added needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. kind:core MSC which is critical to the protocol's success room-spec Something to do with the room version specifications labels Jul 21, 2021

clokep mentioned this pull request Jul 21, 2021

Support MSC3289: Room version 8 matrix-org/synapse#10449

Merged

turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jul 21, 2021

MadLittleMods reviewed Jul 22, 2021

View reviewed changes

proposals/3289-rooms-v8.md Show resolved Hide resolved

clokep commented Jul 27, 2021

View reviewed changes

proposals/3289-rooms-v8.md Show resolved Hide resolved

clokep mentioned this pull request Jul 27, 2021

Restricted rooms (MSC3083) should not have their allow key redacted. matrix-org/synapse#10489

Merged

Update redaction rules.

203c107

uhoreg reviewed Jul 27, 2021

View reviewed changes

proposals/3289-rooms-v8.md Show resolved Hide resolved

richvdh reviewed Jul 27, 2021

View reviewed changes

Revert "Update redaction rules."

0a01646

This reverts commit 203c107.

This was referenced Jul 30, 2021

Note that room versions 7 & 8 exist. matrix-org/sytest#1100

Merged

Use stable room version 8 for MSC3083 tests. matrix-org/complement#181

Merged

mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Aug 8, 2021

turt2live merged commit 55249db into master Aug 8, 2021

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Aug 8, 2021

MadLittleMods mentioned this pull request Aug 10, 2021

Question: Where are the room versions and their changelogs? matrix-org/matrix.org#1043

Closed

richvdh pushed a commit that referenced this pull request Aug 23, 2021

Merge pull request #3289 from matrix-org/clokep/room-v8

b64cdd5

MSC3289: Room version 8

richvdh pushed a commit that referenced this pull request Aug 27, 2021

Merge pull request #3289 from matrix-org/clokep/room-v8

8b1e4d6

MSC3289: Room version 8

turt2live self-assigned this Sep 7, 2021

turt2live mentioned this pull request Sep 8, 2021

join_authorised_via_users_server is not protected from redactions #3373

Closed

turt2live added a commit that referenced this pull request Sep 8, 2021

Room versions 8 and 9: Restricted rooms

e650fca

MSCs: * #3083 * #3289 * #3375

turt2live mentioned this pull request Sep 8, 2021

Room versions 8 and 9: Restricted rooms #3387

Merged

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 8, 2021

jplatte mentioned this pull request Sep 15, 2021

Add unstable support for room version 7, 8 and 9 ruma/ruma#718

Closed

DevinR528 mentioned this pull request Oct 4, 2021

update state-res to handle room versions 7, 8, 9 ruma/ruma#738

Closed

turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jan 18, 2022

clokep deleted the clokep/room-v8 branch May 17, 2023 12:22

S7evinK mentioned this pull request Sep 29, 2023

Declare support for Matrix 1.2 matrix-org/dendrite#3218

Open

16 tasks

matrixbot mentioned this pull request Nov 1, 2024

Declare support for Matrix 1.2 element-hq/dendrite#3218

Open

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC3289: Room version 8 #3289

MSC3289: Room version 8 #3289

clokep commented Jul 21, 2021 •

edited

Loading

ara4n commented Jul 21, 2021 •

edited

Loading

ara4n commented Jul 21, 2021

mscbot commented Jul 21, 2021 •

edited

Loading

anoadragon453 left a comment

richvdh commented Jul 21, 2021

richvdh Jul 27, 2021

clokep Jul 30, 2021

richvdh Aug 2, 2021

clokep Aug 3, 2021

richvdh Aug 3, 2021

richvdh commented Aug 3, 2021

mscbot commented Aug 8, 2021

turt2live commented Sep 8, 2021

turt2live commented Jan 18, 2022

		@@ -0,0 +1,22 @@
		# MSC3289: Room Version 8

		A new room version, `8`, is proposed using [room version 7](https://spec.matrix.org/unstable/rooms/v7/)

MSC3289: Room version 8 #3289

MSC3289: Room version 8 #3289

Conversation

clokep commented Jul 21, 2021 • edited Loading

ara4n commented Jul 21, 2021 • edited Loading

ara4n commented Jul 21, 2021

mscbot commented Jul 21, 2021 • edited Loading

anoadragon453 left a comment

Choose a reason for hiding this comment

richvdh commented Jul 21, 2021

richvdh Jul 27, 2021

Choose a reason for hiding this comment

clokep Jul 30, 2021

Choose a reason for hiding this comment

richvdh Aug 2, 2021

Choose a reason for hiding this comment

clokep Aug 3, 2021

Choose a reason for hiding this comment

richvdh Aug 3, 2021

Choose a reason for hiding this comment

richvdh commented Aug 3, 2021

mscbot commented Aug 8, 2021

turt2live commented Sep 8, 2021

turt2live commented Jan 18, 2022

clokep commented Jul 21, 2021 •

edited

Loading

ara4n commented Jul 21, 2021 •

edited

Loading

mscbot commented Jul 21, 2021 •

edited

Loading