Update the MSC3083 support to verify if joins are from an authorized server #10254

clokep · 2021-06-25T14:24:11Z

MSC3083 was updated to only allow join events to the room if one of the following is true:

The user is already joined or invited to the room.
The join event is signed by a server whose users are able to issue invites for that room.

In order to do this we need to:

Have the join event depend on a membership event in the room (as proof the user can sign the event).
Add our signature when an event comes over federation to send_join.
Check whether a remote join needs to be done, even if the server is in the room already.
Update the auth rules to check the above signature.

Depends on #10268

Complement tests at matrix-org/complement#145

clokep · 2021-06-25T17:01:44Z

(Complement tests failing here are expected.)

clokep · 2021-06-25T17:57:53Z

synapse/handlers/federation.py

        )

        return event

+    async def _get_user_event_which_could_invite(


I'm surprised I don't seem to need to call this in send_join, but I might be getting "lucky" in my testing that the room state hasn't changed between make_join and send_join?

clokep · 2021-06-28T14:08:37Z

synapse/handlers/federation.py

+            additional_auth_ids = [
+                await self._get_user_event_which_could_invite(
+                    room_id, current_state_ids
+                )
+            ]


This same thing needs to be done for a locally issued join.

I'm unsure this is going to work properly, it kind of moves some of the logic about which events to consider in the auth chain to outside of that calculation (see auth_types_for_event). Unfortunately this change means that the events to include in the auth chain depend on the current state of the room (since you need a current membership event in the room to invite).

I'm unsure if this is just some refactoring, or if this breaks an assumption somewhere.

clokep · 2021-06-29T14:47:10Z

I'm going to need to rebase this on #10253 and #10268.

MSC3083 only requires that send_join requests be signed, but it seems consistent to sign all of them. There's no downside to doing this for all room versions, but only MSC3083 room versions care about the additional signature, and only in certain conditions.

This is necessary to "prove" that the signing server has permission to invite users (and thus can sign for a restricted join).

This allows /make_join to complete (which doesn't include a valid signature on the event).

synapse/event_auth.py

synapse/handlers/event_auth.py

synapse/handlers/federation.py

clokep · 2021-07-01T19:42:14Z

This is ready for an initial review. I've left a few open questions that I would appreciate people's thoughts on!

clokep · 2021-07-20T17:46:12Z

Things this needs to do still:

Update error codes to match MSC.
Ensure a send_join goes back to the same server as make_join.

…auth

…actually invite people.

erikjohnston

I think otherwise it looks good

erikjohnston · 2021-07-23T08:31:12Z

synapse/event_auth.py

@@ -637,6 +671,66 @@ def get_user_power_level(user_id: str, auth_events: StateMap[EventBase]) -> int:
            return 0


+def get_users_which_can_issue_invite(auth_events: StateMap[EventBase]) -> List[str]:


I'd be tempted to lift these two functions out of here, as this file is otherwise stuff purely related to the auth rules check from the spec?

synapse/event_auth.py

synapse/federation/federation_server.py

synapse/handlers/event_auth.py

synapse/handlers/room_member.py

Co-authored-by: Erik Johnston <erik@matrix.org>

…auth

erikjohnston

SHIP IT. SHIP IT NOW.

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\matrix-org#10449](matrix-org#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\matrix-org#10449](matrix-org#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\matrix-org#10543](matrix-org#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\matrix-org#10517](matrix-org#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\matrix-org#10531](matrix-org#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\matrix-org#10516](matrix-org#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\matrix-org#9918](matrix-org#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\matrix-org#10245](matrix-org#10245), [\matrix-org#10432](matrix-org#10432), [\matrix-org#10463](matrix-org#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\matrix-org#10254](matrix-org#10254), [\matrix-org#10447](matrix-org#10447), [\matrix-org#10489](matrix-org#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\matrix-org#10283](matrix-org#10283)) - Add a buffered logging handler which periodically flushes itself. ([\matrix-org#10407](matrix-org#10407), [\matrix-org#10515](matrix-org#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\matrix-org#10411](matrix-org#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\matrix-org#10413](matrix-org#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\matrix-org#10426](matrix-org#10426)) - Allow setting transaction limit for database connections. ([\matrix-org#10440](matrix-org#10440), [\matrix-org#10511](matrix-org#10511)) - Add `creation_ts` to "list users" admin API. ([\matrix-org#10448](matrix-org#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\matrix-org#10410](matrix-org#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\matrix-org#10439](matrix-org#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\matrix-org#10455](matrix-org#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\matrix-org#10499](matrix-org#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\matrix-org#10445](matrix-org#10445)) - Consolidate development documentation to `docs/development/`. ([\matrix-org#10453](matrix-org#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\matrix-org#10464](matrix-org#10464)) - Document how to use Complement while developing a new Synapse feature. ([\matrix-org#10483](matrix-org#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\matrix-org#10390](matrix-org#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\matrix-org#10408](matrix-org#10408)) - Remove shebang line from module files. ([\matrix-org#10415](matrix-org#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\matrix-org#10429](matrix-org#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\matrix-org#10431](matrix-org#10431)) - Improve servlet type hints. ([\matrix-org#10437](matrix-org#10437), [\matrix-org#10438](matrix-org#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\matrix-org#10442](matrix-org#10442)) - Update the `tests-done` Github Actions status. ([\matrix-org#10444](matrix-org#10444), [\matrix-org#10512](matrix-org#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\matrix-org#10446](matrix-org#10446), [\matrix-org#10450](matrix-org#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\matrix-org#10451](matrix-org#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\matrix-org#10468](matrix-org#10468)) - Additional type hints in the state handler. ([\matrix-org#10482](matrix-org#10482)) - Update syntax used to run complement tests. ([\matrix-org#10488](matrix-org#10488)) - Fix up type annotations to work with Twisted 21.7. ([\matrix-org#10490](matrix-org#10490)) - Improve type annotations for `ObservableDeferred`. ([\matrix-org#10491](matrix-org#10491)) - Extend release script to also tag and create GitHub releases. ([\matrix-org#10496](matrix-org#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\matrix-org#10500](matrix-org#10500))

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\#10449](matrix-org/synapse#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\#10449](matrix-org/synapse#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\#10543](matrix-org/synapse#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\#10517](matrix-org/synapse#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\#10531](matrix-org/synapse#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\#10516](matrix-org/synapse#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\#9918](matrix-org/synapse#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\#10245](matrix-org/synapse#10245), [\#10432](matrix-org/synapse#10432), [\#10463](matrix-org/synapse#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\#10254](matrix-org/synapse#10254), [\#10447](matrix-org/synapse#10447), [\#10489](matrix-org/synapse#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\#10283](matrix-org/synapse#10283)) - Add a buffered logging handler which periodically flushes itself. ([\#10407](matrix-org/synapse#10407), [\#10515](matrix-org/synapse#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\#10411](matrix-org/synapse#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\#10413](matrix-org/synapse#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\#10426](matrix-org/synapse#10426)) - Allow setting transaction limit for database connections. ([\#10440](matrix-org/synapse#10440), [\#10511](matrix-org/synapse#10511)) - Add `creation_ts` to "list users" admin API. ([\#10448](matrix-org/synapse#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\#10410](matrix-org/synapse#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\#10439](matrix-org/synapse#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\#10455](matrix-org/synapse#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\#10499](matrix-org/synapse#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\#10445](matrix-org/synapse#10445)) - Consolidate development documentation to `docs/development/`. ([\#10453](matrix-org/synapse#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\#10464](matrix-org/synapse#10464)) - Document how to use Complement while developing a new Synapse feature. ([\#10483](matrix-org/synapse#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\#10390](matrix-org/synapse#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\#10408](matrix-org/synapse#10408)) - Remove shebang line from module files. ([\#10415](matrix-org/synapse#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\#10429](matrix-org/synapse#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\#10431](matrix-org/synapse#10431)) - Improve servlet type hints. ([\#10437](matrix-org/synapse#10437), [\#10438](matrix-org/synapse#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\#10442](matrix-org/synapse#10442)) - Update the `tests-done` Github Actions status. ([\#10444](matrix-org/synapse#10444), [\#10512](matrix-org/synapse#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\#10446](matrix-org/synapse#10446), [\#10450](matrix-org/synapse#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\#10451](matrix-org/synapse#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\#10468](matrix-org/synapse#10468)) - Additional type hints in the state handler. ([\#10482](matrix-org/synapse#10482)) - Update syntax used to run complement tests. ([\#10488](matrix-org/synapse#10488)) - Fix up type annotations to work with Twisted 21.7. ([\#10490](matrix-org/synapse#10490)) - Improve type annotations for `ObservableDeferred`. ([\#10491](matrix-org/synapse#10491)) - Extend release script to also tag and create GitHub releases. ([\#10496](matrix-org/synapse#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\#10500](matrix-org/synapse#10500))

@dklimpel

Synapse 1.40.0 (2021-08-10) =========================== No significant changes. Synapse 1.40.0rc3 (2021-08-09) ============================== Features -------- - Support [MSC3289: room version 8](matrix-org/matrix-spec-proposals#3289). ([\matrix-org#10449](matrix-org#10449)) Bugfixes -------- - Mark the experimental room version from [MSC2716](matrix-org/matrix-spec-proposals#2716) as unstable. ([\matrix-org#10449](matrix-org#10449)) Improved Documentation ---------------------- - Fix broken links in `upgrade.md`. Contributed by @dklimpel. ([\matrix-org#10543](matrix-org#10543)) Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\matrix-org#10517](matrix-org#10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\matrix-org#10531](matrix-org#10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\matrix-org#10516](matrix-org#10516)) Synapse 1.40.0rc1 (2021-08-03) ============================== Features -------- - Add support for [MSC2033](matrix-org/matrix-spec-proposals#2033): `device_id` on `/account/whoami`. ([\matrix-org#9918](matrix-org#9918)) - Update support for [MSC2716 - Incrementally importing history into existing rooms](matrix-org/matrix-spec-proposals#2716). ([\matrix-org#10245](matrix-org#10245), [\matrix-org#10432](matrix-org#10432), [\matrix-org#10463](matrix-org#10463)) - Update support for [MSC3083](matrix-org/matrix-spec-proposals#3083) to consider changes in the MSC around which servers can issue join events. ([\matrix-org#10254](matrix-org#10254), [\matrix-org#10447](matrix-org#10447), [\matrix-org#10489](matrix-org#10489)) - Initial support for [MSC3244](matrix-org/matrix-spec-proposals#3244), Room version capabilities over the /capabilities API. ([\matrix-org#10283](matrix-org#10283)) - Add a buffered logging handler which periodically flushes itself. ([\matrix-org#10407](matrix-org#10407), [\matrix-org#10515](matrix-org#10515)) - Add support for https connections to a proxy server. Contributed by @Bubu and @dklimpel. ([\matrix-org#10411](matrix-org#10411)) - Support for [MSC2285 (hidden read receipts)](matrix-org/matrix-spec-proposals#2285). Contributed by @SimonBrandner. ([\matrix-org#10413](matrix-org#10413)) - Email notifications now state whether an invitation is to a room or a space. ([\matrix-org#10426](matrix-org#10426)) - Allow setting transaction limit for database connections. ([\matrix-org#10440](matrix-org#10440), [\matrix-org#10511](matrix-org#10511)) - Add `creation_ts` to "list users" admin API. ([\matrix-org#10448](matrix-org#10448)) Bugfixes -------- - Improve character set detection in URL previews by supporting underscores (in addition to hyphens). Contributed by @srividyut. ([\matrix-org#10410](matrix-org#10410)) - Fix events being incorrectly rejected over federation if they reference auth events that the server needed to fetch. ([\matrix-org#10439](matrix-org#10439)) - Fix `synapse_federation_server_oldest_inbound_pdu_in_staging` Prometheus metric to not report a max age of 51 years when the queue is empty. ([\matrix-org#10455](matrix-org#10455)) - Fix a bug which caused an explicit assignment of power-level 0 to a user to be misinterpreted in rare circumstances. ([\matrix-org#10499](matrix-org#10499)) Improved Documentation ---------------------- - Fix hierarchy of providers on the OpenID page. ([\matrix-org#10445](matrix-org#10445)) - Consolidate development documentation to `docs/development/`. ([\matrix-org#10453](matrix-org#10453)) - Add some developer docs to explain room DAG concepts like `outliers`, `state_groups`, `depth`, etc. ([\matrix-org#10464](matrix-org#10464)) - Document how to use Complement while developing a new Synapse feature. ([\matrix-org#10483](matrix-org#10483)) Internal Changes ---------------- - Prune inbound federation queues for a room if they get too large. ([\matrix-org#10390](matrix-org#10390)) - Add type hints to `synapse.federation.transport.client` module. ([\matrix-org#10408](matrix-org#10408)) - Remove shebang line from module files. ([\matrix-org#10415](matrix-org#10415)) - Drop backwards-compatibility code that was required to support Ubuntu Xenial. ([\matrix-org#10429](matrix-org#10429)) - Use a docker image cache for the prerequisites for the debian package build. ([\matrix-org#10431](matrix-org#10431)) - Improve servlet type hints. ([\matrix-org#10437](matrix-org#10437), [\matrix-org#10438](matrix-org#10438)) - Replace usage of `or_ignore` in `simple_insert` with `simple_upsert` usage, to stop spamming postgres logs with spurious ERROR messages. ([\matrix-org#10442](matrix-org#10442)) - Update the `tests-done` Github Actions status. ([\matrix-org#10444](matrix-org#10444), [\matrix-org#10512](matrix-org#10512)) - Update type annotations to work with forthcoming Twisted 21.7.0 release. ([\matrix-org#10446](matrix-org#10446), [\matrix-org#10450](matrix-org#10450)) - Cancel redundant GHA workflows when a new commit is pushed. ([\matrix-org#10451](matrix-org#10451)) - Mitigate media repo XSS attacks on IE11 via the non-standard X-Content-Security-Policy header. ([\matrix-org#10468](matrix-org#10468)) - Additional type hints in the state handler. ([\matrix-org#10482](matrix-org#10482)) - Update syntax used to run complement tests. ([\matrix-org#10488](matrix-org#10488)) - Fix up type annotations to work with Twisted 21.7. ([\matrix-org#10490](matrix-org#10490)) - Improve type annotations for `ObservableDeferred`. ([\matrix-org#10491](matrix-org#10491)) - Extend release script to also tag and create GitHub releases. ([\matrix-org#10496](matrix-org#10496)) - Fix a bug which caused production debian packages to be incorrectly marked as 'prerelease'. ([\matrix-org#10500](matrix-org#10500))

clokep force-pushed the clokep/restricted-auth branch 3 times, most recently from b49ad33 to a916b43 Compare June 25, 2021 16:16

clokep force-pushed the clokep/restricted-auth branch from a916b43 to 13e207f Compare June 25, 2021 17:33

clokep commented Jun 25, 2021

View reviewed changes

clokep commented Jun 28, 2021

View reviewed changes

clokep force-pushed the clokep/restricted-auth branch 3 times, most recently from 113c864 to eeb199c Compare July 1, 2021 15:25

This was referenced Jul 1, 2021

MSC3083: Restricting room membership based on membership in other rooms matrix-org/matrix-spec-proposals#3083

Merged

Updates to tests for restricted rooms based on changes to MSC3083. matrix-org/complement#145

Merged

clokep added 8 commits July 1, 2021 14:27

Convert compute_auth_events to async.

cb8aaed

Include another user's membership event in the auth events.

f9bfc19

This is necessary to "prove" that the signing server has permission to invite users (and thus can sign for a restricted join).

Update the auth rules to inspect event signatures.

fd37e76

Only perform checks when signature checking is enabled.

59de557

This allows /make_join to complete (which doesn't include a valid signature on the event).

Do not perform a local join if the local server is not authorized.

2a074d3

Newsfragment

d2fdc1b

Update the room version.

441a9bb

clokep force-pushed the clokep/restricted-auth branch from 4c0fa19 to 441a9bb Compare July 1, 2021 18:27

clokep commented Jul 1, 2021

View reviewed changes

synapse/event_auth.py Outdated Show resolved Hide resolved

clokep commented Jul 1, 2021

View reviewed changes

synapse/event_auth.py Outdated Show resolved Hide resolved

clokep commented Jul 1, 2021

View reviewed changes

synapse/handlers/event_auth.py Outdated Show resolved Hide resolved

clokep commented Jul 1, 2021

View reviewed changes

synapse/handlers/federation.py Outdated Show resolved Hide resolved

clokep requested a review from a team July 1, 2021 19:41

babolivier marked this pull request as ready for review July 5, 2021 10:16

erikjohnston self-assigned this Jul 5, 2021

clokep added 2 commits July 19, 2021 10:58

Fix copy & paste error.

8b2cac2

Raise an error if an authorising user cannot be found.

05e35ce

clokep requested a review from erikjohnston July 19, 2021 17:09

Raise errors according to the spec.

a588b7b

clokep added 5 commits July 20, 2021 13:58

Update error codes.

381cc8e

Ensure that /send_join and /make_join go to the same server.

c82c0ce

Merge remote-tracking branch 'origin/develop' into clokep/restricted-…

0437602

…auth

Fix the default power-level of invite and ensure the chosen user can …

3549b5e

…actually invite people.

Filter to local users.

9970af8

clokep mentioned this pull request Jul 21, 2021

Improve failover logic for MSC3083 restricted rooms #10447

Merged

Lint

5aa985d

erikjohnston reviewed Jul 23, 2021

View reviewed changes

clokep and others added 7 commits July 23, 2021 07:12

Fix typo.

8c82dcf

Co-authored-by: Erik Johnston <erik@matrix.org>

Merge remote-tracking branch 'origin/develop' into clokep/restricted-…

4cb62e8

…auth

Prefix the event.

ba070ad

Reduce logging level.

549ca5b

Pipe the room version into auth_types_for_event and use it.

af2c6a5

Move helper code closer to callers.

bc2677b

Fix tests.

6bc22bb

clokep requested a review from erikjohnston July 24, 2021 14:12

clokep mentioned this pull request Jul 26, 2021

Add type hints to state handler. #10482

Merged

erikjohnston approved these changes Jul 26, 2021

View reviewed changes

clokep merged commit 228decf into develop Jul 26, 2021

clokep deleted the clokep/restricted-auth branch July 26, 2021 16:17

richvdh mentioned this pull request Jul 27, 2021

MSC3289: Room version 8 matrix-org/matrix-spec-proposals#3289

Merged

DMRobertson mentioned this pull request Jul 13, 2022

Use state before join to determine if we _should_perform_remote_join #13270

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the MSC3083 support to verify if joins are from an authorized server #10254

Update the MSC3083 support to verify if joins are from an authorized server #10254

clokep commented Jun 25, 2021 •

edited

Loading

clokep commented Jun 25, 2021

clokep Jun 25, 2021

clokep Jun 28, 2021

clokep Jun 28, 2021

clokep commented Jun 29, 2021

clokep commented Jul 1, 2021

clokep commented Jul 20, 2021 •

edited

Loading

erikjohnston left a comment

erikjohnston Jul 23, 2021

erikjohnston left a comment

		@@ -637,6 +671,66 @@ def get_user_power_level(user_id: str, auth_events: StateMap[EventBase]) -> int:
		return 0


		def get_users_which_can_issue_invite(auth_events: StateMap[EventBase]) -> List[str]:

Update the MSC3083 support to verify if joins are from an authorized server #10254

Update the MSC3083 support to verify if joins are from an authorized server #10254

Conversation

clokep commented Jun 25, 2021 • edited Loading

clokep commented Jun 25, 2021

clokep Jun 25, 2021

Choose a reason for hiding this comment

clokep Jun 28, 2021

Choose a reason for hiding this comment

clokep Jun 28, 2021

Choose a reason for hiding this comment

clokep commented Jun 29, 2021

clokep commented Jul 1, 2021

clokep commented Jul 20, 2021 • edited Loading

erikjohnston left a comment

Choose a reason for hiding this comment

erikjohnston Jul 23, 2021

Choose a reason for hiding this comment

erikjohnston left a comment

Choose a reason for hiding this comment

clokep commented Jun 25, 2021 •

edited

Loading

clokep commented Jul 20, 2021 •

edited

Loading