-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify room version 10: knock_restricted
and int power levels
#1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f443b3d.
…' into travis/spec/v10
This was referenced May 30, 2022
richvdh
requested changes
Jun 7, 2022
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@richvdh this should be ready for re-review, with the commits since review being self-contained. |
richvdh
requested changes
Jun 8, 2022
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This was referenced Jun 10, 2022
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates #1082 (and moves it into the room version sections)
Describes MSC3787 -
knock_restricted
Describes MSC3667 - int power levels
Describes MSC3604 - room version 10
Reviewer: This is somewhat set up for commit-by-commit review given diff size, though note the few things pointed out below. #1082 has been incorporated with a merge commit, followed by commits to move it to the right place and such, for example.
Other notable changes with this PR:
There is a bug where**[New in this version]**
(and similar) appears as a literal in the room version spec. clarify federation Authorization header an add destination property #1067 fixes this as it ran into the same problem.Preview: https://pr1099--matrix-spec-previews.netlify.app