Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify room version 10:
knock_restricted
and int power levels #1099Specify room version 10:
knock_restricted
and int power levels #1099Changes from 19 commits
f443b3d
6b175d6
7fd54c4
666baf6
a5a4c1f
503a815
3dd5bee
b2fa4e5
be12f1e
16e7383
3d50019
1f3dc21
0174618
0eec78d
41ed640
5e3175a
56157dc
a8cd1ae
290fa16
1653b43
67d2847
47169fd
1e2f4f6
2b7483a
05ad39d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure about this bit? I've not been able to find any sign of synapse rejecting strings outside this range.
(in any case, what are servers meant to do with PL values outside this range?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is coming from #1082 (comment) which felt small enough to warrant inclusion. Rejection would be the same process as someone specifying a number too large for canonical json, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, the problem here is that Synapse doesn't actually reject such events. Indeed, it doesn't even reject
int
s greater than 2^53 for room versions 1-5, so this text feels particularly misleading here.This is a spec change, and I find it hard to justify without either an MSC or evidence that it's always been this way.