Cast a coroutine into a Deferred in the federation base (#6996)

* commit '380122866': Cast a coroutine into a Deferred in the federation base (#6996)
matrix-org · Mar 24, 2020 · 1bca0d4 · 1bca0d4
2 parents b2e71e3 + 3801228
commit 1bca0d4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/changelog.d/6996.bugfix b/changelog.d/6996.bugfix
@@ -0,0 +1 @@
+Fix bug which caused an error when joining a room, with `'coroutine' object has no attribute 'event_id'`.
diff --git a/synapse/federation/federation_base.py b/synapse/federation/federation_base.py
@@ -96,12 +96,14 @@ def handle_check_result(pdu, deferred):
 
             if not res and pdu.origin != origin:
                 try:
-                    res = yield self.get_pdu(
-                        destinations=[pdu.origin],
-                        event_id=pdu.event_id,
-                        room_version=room_version,
-                        outlier=outlier,
-                        timeout=10000,
+                    res = yield defer.ensureDeferred(
+                        self.get_pdu(
+                            destinations=[pdu.origin],
+                            event_id=pdu.event_id,
+                            room_version=room_version,
+                            outlier=outlier,
+                            timeout=10000,
+                        )
                     )
                 except SynapseError:
                     pass
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix bug which caused an error when joining a room, with `'coroutine' object has no attribute 'event_id'`.