This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Cast a coroutine into a Deferred in the federation base #6996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FederationClient.get_pdu
was made async/await in #6840 (released in 1.110rc1), but a caller of it was not converted. I'm guessing this was missed becauseFederationBase._check_sigs_and_hash_and_fetch
has an inner function which calls back intoFederationBase.get_pdu
(see the mypy errors in #6995).Note that
FederationBase._check_sigs_and_hash_and_fetch
is also used byFederationServer
, so I believe there's potential for another bug here.Part of #6978.