-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): add L2 registry contract (BFT-434) #555
Conversation
Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Seems good to me, matches the design doc. I'm not the best person to review Solidity code though. |
Co-authored-by: Bruno França <bruno@franca.xyz>
@moshababo Let's do a couple of changes here to simplify the contract a bit:
|
Also if possible please merge into |
# Conflicts: # l1-contracts/deploy-scripts/AcceptAdmin.s.sol # l1-contracts/deploy-scripts/DeployErc20.s.sol # system-contracts/package.json # system-contracts/scripts/utils.ts # yarn.lock
l2-contracts/package.json
Outdated
@@ -28,7 +28,8 @@ | |||
"ts-node": "^10.1.0", | |||
"typechain": "^4.0.0", | |||
"typescript": "^5.2.2", | |||
"zksync-ethers": "^5.9.0" | |||
"zksync-ethers": "^5.9.0", | |||
"zksync-web3": "^0.15.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need old SDK?
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
Coverage after merging consensus_contracts into dev will be
Coverage Report |
Co-authored-by: Akosh Farkash <aakoshh@gmail.com> Co-authored-by: Bruno França <bruno@franca.xyz> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> Co-authored-by: Roman Brodetski <Roman.Brodetski@gmail.com> Co-authored-by: vladbochok <vladbochok1@gmail.com>
Co-authored-by: Moshe Shababo <17073733+moshababo@users.noreply.github.com> Co-authored-by: Akosh Farkash <aakoshh@gmail.com> Co-authored-by: Bruno França <bruno@franca.xyz> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> Co-authored-by: Roman Brodetski <Roman.Brodetski@gmail.com> Co-authored-by: vladbochok <vladbochok1@gmail.com>
Co-authored-by: Akosh Farkash <aakoshh@gmail.com> Co-authored-by: Bruno França <bruno@franca.xyz> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> Co-authored-by: Roman Brodetski <Roman.Brodetski@gmail.com> Co-authored-by: vladbochok <vladbochok1@gmail.com>
Co-authored-by: Moshe Shababo <17073733+moshababo@users.noreply.github.com> Co-authored-by: Akosh Farkash <aakoshh@gmail.com> Co-authored-by: Bruno França <bruno@franca.xyz> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> Co-authored-by: Roman Brodetski <Roman.Brodetski@gmail.com> Co-authored-by: vladbochok <vladbochok1@gmail.com>
What ❔
Adding consensus L2 registry contract, to manage attester & validator committees.
Why ❔
Support for PoA deployment.
Checklist