Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consensus): add L2 registry contract (BFT-434) #555

Merged
merged 72 commits into from
Aug 19, 2024
Merged

feat(consensus): add L2 registry contract (BFT-434) #555

merged 72 commits into from
Aug 19, 2024

Commits on Jun 27, 2024

  1. Add consensus L2 contracts

    @moshababo
    moshababo committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    badb7c8 View commit details
    Browse the repository at this point in the history

  2. Add remove func

    @moshababo
    moshababo committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    34b571a View commit details
    Browse the repository at this point in the history

  3. Update l2-contracts/contracts/AttesterRegistry.sol 

    Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
    @moshababo @aakoshh
    moshababo and aakoshh authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1924966 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Update l2-contracts/contracts/ConsensusAuthority.sol 

    Co-authored-by: Bruno França <bruno@franca.xyz>
    @moshababo @brunoffranca
    moshababo and brunoffranca authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0185b43 View commit details
    Browse the repository at this point in the history

  2. Add weight segregation

    @moshababo
    moshababo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    617eb14 View commit details
    Browse the repository at this point in the history

  3. Use nodeOwner address as a UID on registries

    @moshababo
    moshababo committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9f9fb5b View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Add tests (WIP)

    @moshababo
    moshababo committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5580698 View commit details
    Browse the repository at this point in the history

  2. Remove PoP verification

    @moshababo
    moshababo committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8d18140 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Remove epoch, inactivity delay and nextCommittee

    @moshababo
    moshababo committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    53b4d89 View commit details
    Browse the repository at this point in the history

  2. Reorder struct fields for potential packing

    @moshababo
    moshababo committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4e16fce View commit details
    Browse the repository at this point in the history

  3. Optimize gas: iterations

    @moshababo
    moshababo committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b86eaee View commit details
    Browse the repository at this point in the history

  4. Import items explicitly

    @moshababo
    moshababo committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d1e2500 View commit details
    Browse the repository at this point in the history

  5. Use custom errors

    @moshababo
    moshababo committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    bce309a View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Clean delay mechanism leftovers

    @moshababo
    moshababo committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    454d315 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Add top-level setCommittee calls

    @moshababo
    moshababo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a3169ff View commit details
    Browse the repository at this point in the history

  2. Expose committee length

    @moshababo
    moshababo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fe60f1a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge contracts

    @moshababo
    moshababo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0c2498f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Unify validator/attester structs, allow active nodes removal

    @moshababo
    moshababo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    93e8cf8 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Update l2-contracts/contracts/ConsensusRegistry.sol 

    Co-authored-by: Bruno França <bruno@franca.xyz>
    @moshababo @brunoffranca
    moshababo and brunoffranca authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e7fd2e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Add docs

    @moshababo
    moshababo committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    19bfcbd View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'main' into consensus_contracts

    @moshababo
    moshababo authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    07698a3 View commit details
    Browse the repository at this point in the history

  2. Lint

    @moshababo
    moshababo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5aa42a0 View commit details
    Browse the repository at this point in the history

  3. Codespell

    @moshababo
    moshababo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2e5b1cb View commit details
    Browse the repository at this point in the history

  4. Lint

    @moshababo
    moshababo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    eed959e View commit details
    Browse the repository at this point in the history

  5. Prettier

    @moshababo
    moshababo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    9a2f49f View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Use EfficientCall.keccak

    @moshababo
    moshababo committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    31d42cb View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Use underscore prefix in function params

    @moshababo
    moshababo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ca48a30 View commit details
    Browse the repository at this point in the history

  2. Update l2-contracts/contracts/ConsensusRegistry.sol 

    Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
    @moshababo @vladbochok
    moshababo and vladbochok authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    2b861ca View commit details
    Browse the repository at this point in the history

  3. Add docs

    @moshababo
    moshababo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5d80cbc View commit details
    Browse the repository at this point in the history

  4. IsInactive => active

    @moshababo
    moshababo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c4069e3 View commit details
    Browse the repository at this point in the history

  5. Inherit Ownable2Step

    @moshababo
    moshababo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    08b8dbf View commit details
    Browse the repository at this point in the history

  6. Add requires

    @moshababo
    moshababo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6087c4f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'refs/heads/dev' into consensus_contracts 

    # Conflicts:
#	l1-contracts/deploy-scripts/AcceptAdmin.s.sol
#	l1-contracts/deploy-scripts/DeployErc20.s.sol
#	l2-contracts/package.json
#	system-contracts/package.json
#	system-contracts/scripts/utils.ts
#	yarn.lock
    @moshababo
    moshababo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a78f7d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Add zksync-web3 to devDependencies

    @moshababo
    moshababo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7895533 View commit details
    Browse the repository at this point in the history

  2. Lint

    @moshababo
    moshababo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    263ffce View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Use plain msg.sender

    @moshababo
    moshababo committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8c54279 View commit details
    Browse the repository at this point in the history

  2. Add custom errors for input validation

    @moshababo
    moshababo committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e04b7bb View commit details
    Browse the repository at this point in the history

  3. Add events emission

    @moshababo
    moshababo committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    92b0fcc View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Use fixed-size types

    @moshababo
    moshababo committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a5b796c View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. [WIP] apply latest/snapshot data modes, to be read from according to … 

    …the latest commit
    @moshababo
    moshababo committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c13bd81 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Change nodes removal scheme

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ec36993 View commit details
    Browse the repository at this point in the history

  2. Assign latest commit number when updating

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    167bcfd View commit details
    Browse the repository at this point in the history

  3. Apply _ prefix naming convention

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9137d35 View commit details
    Browse the repository at this point in the history

  4. Change Secp256k1PublicKey fields naming

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3fe085f View commit details
    Browse the repository at this point in the history

  5. Update contract doc

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4b717f9 View commit details
    Browse the repository at this point in the history

  6. Add pubKey hashes mapping for efficient lookups

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e2ea3de View commit details
    Browse the repository at this point in the history

  7. Add docs

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    89b4ccd View commit details
    Browse the repository at this point in the history

  8. Fix Secp256k1PublicKey struct literal

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f842a7d View commit details
    Browse the repository at this point in the history

  9. Unify NodeValidatorPoPChanged and NodeAttesterPubKeyChanged events

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    347229d View commit details
    Browse the repository at this point in the history

  10. Add IConsensusRegistry

    @moshababo
    moshababo committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f90aa99 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Remove from node owners array without index finding iteration

    @moshababo
    moshababo committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    feb76be View commit details
    Browse the repository at this point in the history

  2. Remove unneeded mapping

    @moshababo
    moshababo committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8fd2100 View commit details
    Browse the repository at this point in the history

  3. Add the commit counter to commit events as an arg

    @moshababo
    moshababo committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4157991 View commit details
    Browse the repository at this point in the history

  4. Docs refactor

    @moshababo
    moshababo committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    10b601a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Improve pending removal inspection

    @moshababo
    moshababo committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    655f4b5 View commit details
    Browse the repository at this point in the history

  2. remove to potentially trigger a deletion

    @moshababo
    moshababo committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    10d7d53 View commit details
    Browse the repository at this point in the history

  3. Add NodeDeleted event

    @moshababo
    moshababo committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    7a2a755 View commit details
    Browse the repository at this point in the history

  4. Add _getNode getter

    @moshababo
    moshababo committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2c25a50 View commit details
    Browse the repository at this point in the history

  5. Add committees read functions

    @moshababo
    moshababo committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    262adb6 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Update existing tests

    @moshababo
    moshababo committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    bb12557 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @moshababo
    moshababo committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    939e96b View commit details
    Browse the repository at this point in the history

  3. pack storage (uint256 -> uint32)

    @moshababo
    moshababo committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    a973b21 View commit details
    Browse the repository at this point in the history

  4. Rename function

    @moshababo
    moshababo committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    7ed0bd3 View commit details
    Browse the repository at this point in the history

  5. eslint

    @moshababo
    moshababo committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    e8a32b7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'refs/heads/dev' into consensus_contracts 

    # Conflicts:
#	l1-contracts/deploy-scripts/AcceptAdmin.s.sol
#	l1-contracts/deploy-scripts/DeployErc20.s.sol
#	system-contracts/package.json
#	system-contracts/scripts/utils.ts
#	yarn.lock
    @moshababo
    moshababo committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    82e44f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Update l2-contracts/contracts/ConsensusRegistry.sol 

    Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
    @RomanBrodetski @vladbochok
    RomanBrodetski and vladbochok authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    460de55 View commit details
    Browse the repository at this point in the history

  2. Update l2-contracts/contracts/ConsensusRegistry.sol 

    Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
    @RomanBrodetski @vladbochok
    RomanBrodetski and vladbochok authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2ebcc2d View commit details
    Browse the repository at this point in the history

  3. Update l2-contracts/contracts/ConsensusRegistry.sol 

    Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
    @RomanBrodetski @vladbochok
    RomanBrodetski and vladbochok authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a1ac4c3 View commit details
    Browse the repository at this point in the history

  4. Update l2-contracts/contracts/ConsensusRegistry.sol 

    Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
    @RomanBrodetski @vladbochok
    RomanBrodetski and vladbochok authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0c4dec1 View commit details
    Browse the repository at this point in the history

  5. Fix the compilation

    @vladbochok
    vladbochok committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5111248 View commit details
    Browse the repository at this point in the history

  6. Add comment on proxy usage

    @vladbochok
    vladbochok committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    43893b0 View commit details
    Browse the repository at this point in the history

  7. Integrate Proxy

    @vladbochok
    vladbochok committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d4f454a View commit details
    Browse the repository at this point in the history