Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch all factory deps for a given contract #316

Merged
merged 27 commits into from
Apr 18, 2024
Merged

fix: fetch all factory deps for a given contract #316

merged 27 commits into from
Apr 18, 2024

Commits on Apr 11, 2024

  1. fix(compile:zk): use factory deps from compilation

    @Karrq
    Karrq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1873d96 View commit details
    Browse the repository at this point in the history

  2. algo

    @Karrq
    Jrigada authored and Karrq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e7a1264 View commit details
    Browse the repository at this point in the history

  3. feat(create:zk): fetch all unique factory deps 

    chore: impl FetchContract for &[DualCompiledContract]
refactor(create:zk): avoid modifying provided list of factory_deps
during deploy
fix(create:zk): simplify factory dep search algo
    @Karrq
    Karrq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8631f6c View commit details
    Browse the repository at this point in the history

  4. move fetch factory deps to FindContract trait

    @Karrq
    Jrigada authored and Karrq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    4ce160c View commit details
    Browse the repository at this point in the history

  5. fix(zkvm:broadcast): fetch all factory_deps

    @Karrq
    Karrq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    75f82b8 View commit details
    Browse the repository at this point in the history

  6. fix(zkvm:create): fetch all factory deps

    @Karrq
    Karrq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    36f32f7 View commit details
    Browse the repository at this point in the history

  7. chore: cleanup & todos

    @Karrq
    Karrq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    96bcb0e View commit details
    Browse the repository at this point in the history

  8. tests(zk): add Factory family of tests

    @Karrq
    Karrq committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    44a5778 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. refactor: dedicated DualCompiledContracts

    @Karrq
    Karrq committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9d44a95 View commit details
    Browse the repository at this point in the history

  2. fix(test:zk): Factory contract cleanup

    @Karrq
    Karrq committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    78199a4 View commit details
    Browse the repository at this point in the history

  3. fix(call:zk): pass factory deps 

    fix(test:zk): proper user factory
    @Karrq
    Karrq committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5a1a8b3 View commit details
    Browse the repository at this point in the history

  4. chore: fmt

    @Karrq
    Karrq committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b776171 View commit details
    Browse the repository at this point in the history

  5. fix(zk:create): restore handle --factory-deps 

    feat(zk:create): lookup all factory deps of manually specified deps
    @Karrq
    Karrq committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b274948 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. refactory(test:zk): split Factory tests & sources 

    feat(test:zk): add scripts for factory tests
fix(test:zk): comment out non working test & add FIXME
    @Karrq
    Karrq committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    fdcf193 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into fix/nested-factory-deps

    @HermanObst
    HermanObst authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0cd560c View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. chore(docs): formatting 

    Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com>
    @Karrq @nbaztec
    Karrq and nbaztec authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e7cbe94 View commit details
    Browse the repository at this point in the history

  2. feat(zkvm): persist seen factory deps 

    fix(tests:zk): enable `testUserFactory`
refactor(compile:zk): `fetch_all_factory_deps` return `Vec<Vec<u8>>`
    @Karrq
    Karrq committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    57a8720 View commit details
    Browse the repository at this point in the history

  3. chore: lints

    @Karrq
    Karrq committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4a747c3 View commit details
    Browse the repository at this point in the history

  4. add docs

    @nbaztec
    nbaztec committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b18d559 View commit details
    Browse the repository at this point in the history

  5. fix(zk:etch): avoid to_checked 

    fix(zk:factory_dep): load from storage first, then persisted deps
    @Karrq
    Karrq committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0396e6b View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/dev' into fix/nested-factory-deps

    @Karrq
    Karrq committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    58521b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. refactor: persisted_factory_deps field as pub

    @Karrq
    Karrq committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b0b1309 View commit details
    Browse the repository at this point in the history

  2. fix(zk:storage): read from persisted first

    @Karrq
    Karrq committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ee9b7fa View commit details
    Browse the repository at this point in the history

  3. feat(zk): ZKVMData::with_extra_factory_deps 

    refactor(zk): remove persisted factory deps from `StorageView`
refactor(zk:call): remove dead code
    @Karrq
    Karrq committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    615e7eb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into fix/nested-factory-deps

    @Karrq
    Karrq authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4c8b5fd View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. docs(zk): factory deps explanations 

    Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com>
    @Karrq @nbaztec
    Karrq and nbaztec authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dcc0f91 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into fix/nested-factory-deps

    @HermanObst
    HermanObst authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    81616fa View commit details
    Browse the repository at this point in the history