fix: fetch all factory deps for a given contract #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: impl FetchContract for &[DualCompiledContract] refactor(create:zk): avoid modifying provided list of factory_deps during deploy fix(create:zk): simplify factory dep search algo
Karrq
force-pushed
the
fix/nested-factory-deps
branch
from
4f0ef0d
to
44a5778
Compare
nbaztec
reviewed
Apr 12, 2024
fix(test:zk): proper user factory
feat(zk:create): lookup all factory deps of manually specified deps
feat(test:zk): add scripts for factory tests fix(test:zk): comment out non working test & add FIXME
|
Lets wait to adding aave-delivery test into the CI before merging this PR. Today should be added :) |
nbaztec
reviewed
Apr 15, 2024
Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com>
fix(tests:zk): enable `testUserFactory` refactor(compile:zk): `fetch_all_factory_deps` return `Vec<Vec<u8>>`
nbaztec
reviewed
Apr 16, 2024
fix(zk:factory_dep): load from storage first, then persisted deps
refactor(zk): remove persisted factory deps from `StorageView` refactor(zk:call): remove dead code
nbaztec
reviewed
Apr 17, 2024
| let persisted_factory_deps = self.persisted_factory_deps.clone(); | ||
| // and extend it for future calls | ||
| self.persisted_factory_deps | ||
| .extend(factory_deps.iter().map(|dep| (hash_bytecode(dep), dep.clone()))); |
There was a problem hiding this comment.
As a follow up, we should try to remove this part, and perhaps extend it only with the bytecodes returned from the era vm. So in theory, every known bytecode will reside here. Or perhaps we can also think if it's easier to support it directly in the Backend and via some changes to DatabaseExt to actually store the factory_deps directly in the storage. But that all can be a later refactor.
nbaztec
reviewed
Apr 17, 2024
nbaztec
reviewed
Apr 17, 2024
nbaztec
approved these changes
Apr 17, 2024
Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently deploying factory-style contracts requires specifying almost all dependencies manually (via something like
--factory-deps).Addressing this issue would resolve #295 as well.
Solution
Use the factory deps information provided by the compiler and bundle them in the transactions when creating contracts with factory dependencies, also performing a search to find any nested dependencies, since the compiler only returns the first level of dependencies.
Notes
The following tests fail:
testUserFactory