-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prover): add GPU feature for compressor #1838
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # prover/Cargo.lock # prover/Cargo.toml # prover/proof_fri_compressor/Cargo.toml
Artemka374
force-pushed
the
afo/gpu-compressors
branch
from
May 7, 2024 14:41
927be96
to
0f31e73
Compare
EmilLuta
reviewed
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Left a few questions as I try to understand the changes.
Artemka374
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet and
otani88
May 8, 2024 10:41
Artemka374
force-pushed
the
afo/gpu-compressors
branch
from
May 9, 2024 08:43
19102d0
to
1db57ba
Compare
alexandrst88
requested changes
May 20, 2024
perekopskiy
reviewed
May 21, 2024
Artemka374
force-pushed
the
afo/gpu-compressors
branch
from
May 21, 2024 10:47
9631966
to
94ad708
Compare
perekopskiy
reviewed
May 21, 2024
perekopskiy
previously approved these changes
May 21, 2024
alexandrst88
approved these changes
May 21, 2024
This was referenced May 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2024
🤖 I have created a release *beep* *boop* --- ## [24.4.0](core-v24.3.0...core-v24.4.0) (2024-05-21) ### Features * **prover:** add GPU feature for compressor ([#1838](#1838)) ([e9a2213](e9a2213)) * **pruning:** remove manual vaccum; add migration configuring autovacuum ([#1983](#1983)) ([3d98072](3d98072)) * **tests:** Move all env calls to one place in ts-tests ([#1968](#1968)) ([3300047](3300047)) ### Bug Fixes * Disallow non null updates for transactions ([#1951](#1951)) ([a603ac8](a603ac8)) * **en:** Minor node fixes ([#1978](#1978)) ([74144e8](74144e8)) * **en:** run `MainNodeFeeParamsFetcher` in API component ([#1988](#1988)) ([b62677e](b62677e)) * **merkle-tree:** Fix tree API health check status ([#1973](#1973)) ([6235561](6235561)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 23, 2024
🤖 I have created a release *beep* *boop* --- ## [14.3.0](prover-v14.2.0...prover-v14.3.0) (2024-05-23) ### Features * **config:** remove zksync home ([#2022](#2022)) ([d08fe81](d08fe81)) * **prover_cli:** add general status for batch command ([#1953](#1953)) ([7b0df3b](7b0df3b)) * **prover:** add GPU feature for compressor ([#1838](#1838)) ([e9a2213](e9a2213)) ### Bug Fixes * **prover:** Fix path to vk_setup_data_generator_server_fri ([#2025](#2025)) ([dbe4d6f](dbe4d6f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Integrate GPU proof compressors into monorepo.
GPU compressors can be run with
gpu
feature.Why ❔
Running compressors with GPU significantly improves efficiency.
CPU compressor average proving time - 15 minutes
GPU compressor average proving time - 2 minutes
Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.