Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(merkle-tree): Fix tree API health check status #1973

Merged
merged 4 commits into from
May 17, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented May 17, 2024

What ❔

  • Makes health status "affected" if the tree API is not available.
  • Distinguishes between "tree API not enabled on the node" and "tree API temporarily unavailable" errors.

Why ❔

Right now, the status is "not ready", meaning that the entire app health status is "not ready" as well. This makes API servers excluded from serving traffic, which is not desirable (they can still serve all of requests other than zks_getProof).

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@slowli slowli marked this pull request as ready for review May 17, 2024 09:03
core/lib/web3_decl/src/error.rs Show resolved Hide resolved
@slowli slowli added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 6235561 May 17, 2024
46 checks passed
@slowli slowli deleted the aov-pla-937-fix-tree-api-health-check-status branch May 17, 2024 11:12
github-merge-queue bot pushed a commit that referenced this pull request May 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.4.0](core-v24.3.0...core-v24.4.0)
(2024-05-21)


### Features

* **prover:** add GPU feature for compressor
([#1838](#1838))
([e9a2213](e9a2213))
* **pruning:** remove manual vaccum; add migration configuring
autovacuum
([#1983](#1983))
([3d98072](3d98072))
* **tests:** Move all env calls to one place in ts-tests
([#1968](#1968))
([3300047](3300047))


### Bug Fixes

* Disallow non null updates for transactions
([#1951](#1951))
([a603ac8](a603ac8))
* **en:** Minor node fixes
([#1978](#1978))
([74144e8](74144e8))
* **en:** run `MainNodeFeeParamsFetcher` in API component
([#1988](#1988))
([b62677e](b62677e))
* **merkle-tree:** Fix tree API health check status
([#1973](#1973))
([6235561](6235561))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants