fix(eth-client): Make block params non-optional #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
approved these changes
May 8, 2024
montekki
approved these changes
May 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
perekopskiy
pushed a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- ## [24.2.0](core-v24.1.0...core-v24.2.0) (2024-05-14) ### Features * **api:** Add zeppelinos well-known slots ([#1892](#1892)) ([1c041cc](1c041cc)) * **en:** Brush up EN observability config ([#1897](#1897)) ([086f768](086f768)) * **node_framework:** Add tree api server & client to the metadata calculator ([#1885](#1885)) ([6dda157](6dda157)) ### Bug Fixes * **core/prover:** Changes to support Validium ([#1910](#1910)) ([1cb0dc5](1cb0dc5)) * **eth-client:** Fix call error detection ([#1890](#1890)) ([c22ce63](c22ce63)) * **eth-client:** Make block params non-optional ([#1882](#1882)) ([3005862](3005862)) * **pruning:** Don't require metadata to exist for first L1 batches to be pruned ([#1850](#1850)) ([75c8565](75c8565)) * **pruning:** query optimization ([#1904](#1904)) ([9154390](9154390)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fixes passing
nullparameters where RPC providers don't expect them.Why ❔
Without the fix, L1 client is broken.
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.