Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/prover): Changes to support Validium #1910

Merged
merged 21 commits into from
May 14, 2024
Merged

fix(core/prover): Changes to support Validium #1910

merged 21 commits into from
May 14, 2024

Conversation

EmilLuta
Copy link
Contributor

No description provided.

@koloz193 koloz193 changed the title DO NOT MERGE -- Validium fix visual diff chore(core/prover): fix validium May 13, 2024
@EmilLuta EmilLuta changed the title chore(core/prover): fix validium fix(core/prover): Changes to support Validium May 13, 2024
@EmilLuta EmilLuta requested a review from a team as a code owner May 13, 2024 11:41
@koloz193 koloz193 requested a review from popzxc May 13, 2024 12:37
@koloz193 koloz193 requested a review from mm-zk May 13, 2024 12:37
@EmilLuta
Copy link
Contributor Author

LGTM

popzxc
popzxc approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seriously bothers me that we have more and more abstractions implemented for either rollup or validium (ideally we should have exactly 1, switching the rollup to either mode, or at the very least a factory), but otherwise lgtm

perekopskiy
perekopskiy approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@perekopskiy perekopskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommitmentPostProcessor and InputGenerator look a bit hacky. Probably it would be better if the whole logic of commitment generation was abstracted -- but it can require some code duplication between Rollup and Validium impls.

@koloz193
Copy link
Contributor

CommitmentPostProcessor and InputGenerator look a bit hacky. Probably it would be better if the whole logic of commitment generation was abstracted -- but it can require some code duplication between Rollup and Validium impls.

agreed, i debated between code duplication and having a specialized sub-component. the thing i wanted to avoid was ending up in a scenario where we make an update to CommitmentGenerator and needed to update all of the impls

yorik
yorik approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@yorik yorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI approved

@perekopskiy perekopskiy merged commit 1cb0dc5 into main May 14, 2024
50 checks passed
@perekopskiy perekopskiy deleted the zk-validium-fix branch May 14, 2024 08:41
This was referenced May 14, 2024
Merged
Merged
perekopskiy pushed a commit that referenced this pull request May 14, 2024
@zksync-era-bot
chore(main): release core 24.2.0 (#1889)
41f74cd 
🤖 I have created a release *beep* *boop*
---


##
[24.2.0](core-v24.1.0...core-v24.2.0)
(2024-05-14)


### Features

* **api:** Add zeppelinos well-known slots
([#1892](#1892))
([1c041cc](1c041cc))
* **en:** Brush up EN observability config
([#1897](#1897))
([086f768](086f768))
* **node_framework:** Add tree api server & client to the metadata
calculator
([#1885](#1885))
([6dda157](6dda157))


### Bug Fixes

* **core/prover:** Changes to support Validium
([#1910](#1910))
([1cb0dc5](1cb0dc5))
* **eth-client:** Fix call error detection
([#1890](#1890))
([c22ce63](c22ce63))
* **eth-client:** Make block params non-optional
([#1882](#1882))
([3005862](3005862))
* **pruning:** Don't require metadata to exist for first L1 batches to
be pruned
([#1850](#1850))
([75c8565](75c8565))
* **pruning:** query optimization
([#1904](#1904))
([9154390](9154390))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
perekopskiy added a commit that referenced this pull request May 14, 2024
@zksync-era-bot @perekopskiy
chore(main): release prover 14.1.1 (#1922)
0bd27a1 
🤖 I have created a release *beep* *boop*
---


##
[14.1.1](prover-v14.1.0...prover-v14.1.1)
(2024-05-14)


### Bug Fixes

* **core/prover:** Changes to support Validium
([#1910](#1910))
([1cb0dc5](1cb0dc5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@popzxc popzxc popzxc approved these changes

@yorik yorik yorik approved these changes

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@mm-zk mm-zk Awaiting requested review from mm-zk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EmilLuta @koloz193 @yorik @popzxc @perekopskiy