feat(state-keeper): circuits seal criterion #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/lib/multivm/src/versions/vm_latest/tracers/circuits_capacity.rs
Outdated
Show resolved
Hide resolved
core/lib/multivm/src/versions/vm_latest/tracers/circuits_tracer.rs
Outdated
Show resolved
Hide resolved
core/lib/multivm/src/versions/vm_latest/tracers/circuits_tracer.rs
Outdated
Show resolved
Hide resolved
core/lib/multivm/src/versions/vm_latest/tracers/circuits_tracer.rs
Outdated
Show resolved
Hide resolved
core/lib/multivm/src/versions/vm_latest/tracers/circuits_tracer.rs
Outdated
Show resolved
Hide resolved
core/lib/multivm/src/versions/vm_latest/tracers/circuits_tracer.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/state_keeper/seal_criteria/criteria/geometry_seal_criteria.rs
Show resolved
Hide resolved
I'm working on tests. Wanted to get confirmation that the approach makes sense before starting |
core/lib/multivm/src/versions/vm_latest/tracers/circuits_tracer.rs
Outdated
Show resolved
Hide resolved
StanislavBreadless
previously approved these changes
Jan 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
StanislavBreadless
approved these changes
Jan 5, 2024
Detected VM performance changes
|
mm-zk
reviewed
Jan 5, 2024
| @@ -450,6 +450,7 @@ impl BlocksDal<'_, '_> { | |||
| predicted_block_gas: BlockGasCount, | |||
| events_queue: &[LogQuery], | |||
| storage_refunds: &[u32], | |||
| predicted_circuits: u32, | |||
There was a problem hiding this comment.
where is a good place to add the description on what 'predicted_circuits' mean?
There was a problem hiding this comment.
I think adding a comment to this method declaration will work best, will add it with the next PR I open
This was referenced Jan 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [19.1.0](core-v19.0.0...core-v19.1.0) (2024-01-10) ### Features * address remaining spelling issues in dev comments and turns on dev_comments in cfg ([#827](#827)) ([1fd0afd](1fd0afd)) * **core:** removes multiple tokio runtimes and worker number setting. ([#826](#826)) ([b8b190f](b8b190f)) * fix spelling in dev comments in `core/lib/*` - continued ([#683](#683)) ([0421fe6](0421fe6)) * fix spelling in dev comments in `core/lib/*` - continued ([#684](#684)) ([b46c2e9](b46c2e9)) * fix spelling in dev comments in `core/lib/multivm` - continued ([#682](#682)) ([3839d39](3839d39)) * fix spelling in dev comments in `core/lib/zksync_core` - continued ([#685](#685)) ([70c3feb](70c3feb)) * **state-keeper:** circuits seal criterion ([#729](#729)) ([c4a86bb](c4a86bb)) * **state-keeper:** Reject transactions that fail to publish bytecodes ([#832](#832)) ([0a010f0](0a010f0)) * **vm:** Add batch input abstraction ([#817](#817)) ([997db87](997db87)) ### Bug Fixes * oldest unpicked batch ([#692](#692)) ([a6c869d](a6c869d)) * **state-keeper:** Updates manager keeps track of fictive block metrics ([#843](#843)) ([88fd724](88fd724)) * **vm:** fix circuit tracer ([#837](#837)) ([83fc7be](83fc7be)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
🤖 I have created a release *beep* *boop* --- ## [11.0.0](prover-v10.1.0...prover-v11.0.0) (2024-01-29) ### ⚠ BREAKING CHANGES * **vm:** fee model updates + 1.4.1 ([#791](#791)) ### Features * **api:** Make Web3 API server work with pruned data ([#838](#838)) ([0b7cd0b](0b7cd0b)) * consensus component config for main node and external node ([#881](#881)) ([1aed8de](1aed8de)) * **en:** Restore state keeper storage from snapshot ([#885](#885)) ([a9553b5](a9553b5)) * fee model updates + 1.4.1 stage upgrade ([#897](#897)) ([fa48c13](fa48c13)) * protobuf-generated json configs for the main node (BFT-371) ([#458](#458)) ([f938314](f938314)) * Remove zkevm_test_harness public reexport from zksync_types ([#929](#929)) ([dd1a35e](dd1a35e)) * **state-keeper:** circuits seal criterion ([#729](#729)) ([c4a86bb](c4a86bb)) * **vm:** fee model updates + 1.4.1 ([#791](#791)) ([3564aff](3564aff)) ### Bug Fixes * address issue with spellchecker not checking against prover workspace ([#855](#855)) ([4f55926](4f55926)) * addresses broken links in preparation for ci link check ([#869](#869)) ([a78d03c](a78d03c)) * **prover:** Update shivini ([#915](#915)) ([f141a00](f141a00)) * **witness-generator:** Update era-zkevm_test_harness ([#912](#912)) ([c03c2e3](c03c2e3)) * **witness-generator:** Update zkevm_test_harness ([#930](#930)) ([16fdcff](16fdcff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
ComputationGasCriterionwith more preciseCircuitsCriterionWhy ❔
Introduce
CircuitsCriterionfor efficient batch sealingChecklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.