Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): detailed circuit statistic #845

Merged
merged 26 commits into from
Jan 26, 2024
Merged

Conversation

perekopskiy
Copy link
Contributor

@perekopskiy perekopskiy commented Jan 9, 2024

What ❔

Adds statistic with a number of circuit estimated for each circuit type.

Why ❔

Better visibility/tests/debugging opportunity

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@perekopskiy perekopskiy marked this pull request as ready for review January 9, 2024 14:51
@perekopskiy perekopskiy marked this pull request as draft January 9, 2024 15:10
@perekopskiy perekopskiy marked this pull request as ready for review January 11, 2024 09:59
mm-zk
mm-zk previously approved these changes Jan 15, 2024
Copy link
Collaborator

@mm-zk mm-zk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it !

core/lib/zksync_core/src/reorg_detector/tests.rs Outdated Show resolved Hide resolved
core/lib/types/Cargo.toml Outdated Show resolved Hide resolved
@perekopskiy perekopskiy added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit a20af60 Jan 26, 2024
27 checks passed
@perekopskiy perekopskiy deleted the detailed-circuit-statistic branch January 26, 2024 12:57
joonazan pushed a commit that referenced this pull request Jan 30, 2024
## What ❔

Adds statistic with a number of circuit estimated for each circuit type.

## Why ❔

Better visibility/tests/debugging opportunity

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
- [x] Spellcheck has been run via `zk spellcheck`.
github-merge-queue bot pushed a commit that referenced this pull request Jan 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[20.2.0](core-v20.1.0...core-v20.2.0)
(2024-01-30)


### Features

* added unauthenticated version of gcs object store
([#916](#916))
([638a813](638a813))
* Adding EN snapshots applier
([#882](#882))
([0d2ba09](0d2ba09))
* consensus component config for main node and external node
([#881](#881))
([1aed8de](1aed8de))
* **en:** Make ENs detect reorgs earlier
([#964](#964))
([b043cc8](b043cc8))
* **en:** Restore state keeper storage from snapshot
([#885](#885))
([a9553b5](a9553b5))
* protobuf-generated json configs for the main node (BFT-371)
([#458](#458))
([f938314](f938314))
* Remove zkevm_test_harness public reexport from zksync_types
([#929](#929))
([dd1a35e](dd1a35e))
* **state-keeper:** track the time that individual transactions spend in
mempool ([#941](#941))
([fa45aa9](fa45aa9))
* **vm:** detailed circuit statistic
([#845](#845))
([a20af60](a20af60))
* **vm:** Support tracers for old vm
([#926](#926))
([9fc2d95](9fc2d95))


### Bug Fixes

* **api:** Order transaction traces in `debug_traceBlock*` methods
([#924](#924))
([5918ef9](5918ef9))
* **db:** Make `get_expected_l1_batch_timestamp()` more efficient
([#963](#963))
([7334679](7334679))
* **db:** Make `snapshot_recovery` migration backward-compatible
([#961](#961))
([e756762](e756762))
* **zksync_types:** Update SerializationTransactionError::OversizedData
description
([#949](#949))
([c95f3ee](c95f3ee))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants