-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #82 and #79 #109
Revert #82 and #79 #109
Conversation
Is the missing functionality written anywhere? Can't that be completed without reverting the code? |
Thanks @mickmister I see this working as expected for the reverts. As we are making a last set of changes here, Can you please add something to the read-me that covers an example of using the new guest-account support feature?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @mickmister
@DHaussermann I'm inclined to do this in a separate PR as it's out of scope of reverting these two PRs. Thoughts on merging this PR as-is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed as per comment above.
Read M edit will be addressed separately.
LGTM!
Summary
Reverts the following PRs due to having incomplete functionality:
team-a,team-b
in the messages #82I've also reopened the tickets associated with those PRs:
Ticket Link