Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.3.0 #105

Merged
merged 2 commits into from
May 2, 2023
Merged

Bump version to 1.3.0 #105

merged 2 commits into from
May 2, 2023

Conversation

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 29, 2023
@trilopin
Copy link

trilopin commented May 2, 2023

@mickmister note that lint is failing in CI

@mickmister mickmister requested review from trilopin and removed request for trilopin May 2, 2023 15:05
@mickmister mickmister merged commit 98fd324 into master May 2, 2023
@mickmister mickmister deleted the release-bump-1.3.0 branch May 2, 2023 19:29
@DHaussermann
Copy link

DHaussermann commented May 4, 2023

I have done some testing on this release and there are issues:
1. The issue is fixed but, I can't make that work as a feature. It will just never welcome guests. Maybe I tried this wrong. @streamer45 maybe you have thoughts on this?
- Created a guest user and invited them to a team with working welcome message. When the new user logs in for the 1st time they don't get the bot DM even when I add the new field to my config
image

  1. There's a feature where you can welcome multiple teams that does not work and should be reverted - [mm-65] Allows users to add multiple teams to the messages using team-a,team-b in the messages #82
  2. Theres a feature where we add channel level welcome support to private channels that does not work and should be reverted - solves Gh 72 - Welcome bot will not let me add a message to private channels #79

@mickmister may be able to help on 2. and 3.

@DHaussermann
Copy link

@streamer45 disregard the comment above. This does work as expected. On some attempts to test I forgot to restart the server. And on the last attempt there was a syntax error (which you can even see in the screen shot 🙃)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants