Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that you can set channel welcome message & fix JSON indentation #60

Merged
merged 6 commits into from
Jan 13, 2021
Merged

Clarify that you can set channel welcome message & fix JSON indentation #60

merged 6 commits into from
Jan 13, 2021

Conversation

bbodenmiller
Copy link
Contributor

@bbodenmiller bbodenmiller commented Oct 23, 2020 •
edited
Loading

Summary

Clarify that you can set channel welcome message

Ticket Link

@mattermod
Copy link
Contributor

Hello @bbodenmiller,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@hanzei hanzei added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer labels Oct 24, 2020
@bbodenmiller bbodenmiller changed the title Clarify that you can set channel welcome message Clarify that you can set channel welcome message & fix JSON indentation Oct 24, 2020
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Oct 26, 2020
View reviewed changes
Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions and need to confirm whether "account manager" is the correct role.

jfrerich
jfrerich approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bbodenmiller! LGTM, but please merge @justinegeffen's suggestions 🚀

@bbodenmiller @justinegeffen
Apply suggestions from code review
c6f0bca 
Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@bbodenmiller
Copy link
Contributor Author

@jfrerich applied all but one because it's just an example and I don't think Customer Engineer is a widely used role name.

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

@jasonblais
Copy link
Contributor

@justinegeffen ready for re-review

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

@jfrerich
Copy link
Contributor

@justinegeffen, gentle reminder to review this PR :)

justinegeffen
justinegeffen reviewed Jan 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Jan 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Jan 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Jan 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Jan 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Jan 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
justinegeffen
justinegeffen reviewed Jan 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@justinegeffen justinegeffen added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer Lifecycle/1:stale labels Jan 13, 2021
@justinegeffen justinegeffen merged commit 9eb5794 into mattermost-community:master Jan 13, 2021
@mickmister mickmister mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinegeffen justinegeffen justinegeffen approved these changes

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bbodenmiller @mattermod @jasonblais @jfrerich @justinegeffen @hanzei