How to enable SSL pinning on mobile #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
Do Not Merge
|
Newest code from enahum has been published to preview environment for Git SHA 62a4d2d |
jwilander
approved these changes
Jul 5, 2024
site/content/contribute/more-info/mobile/build-your-own/ssl-pinning.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joram Wilander <jwawilander@gmail.com>
|
Newest code from enahum has been published to preview environment for Git SHA 3316760 |
coltoneshaw
approved these changes
Jul 8, 2024
|
@cwarnermm any idea how to achieve Colton's suggestion ? |
|
@enahum @coltoneshaw - My latest commit adds an Important Note directly after the disadvantages list: Feel free to suggest changes directly in this PR if needed. |
|
Newest code from cwarnermm has been published to preview environment for Git SHA 4178e6d |
|
Newest code from cwarnermm has been published to preview environment for Git SHA b855d0d |
sbishel
approved these changes
Jul 17, 2024
esarafianou
approved these changes
Jul 23, 2024
enahum
added
4: Reviews Complete
|
Newest code from enahum has been published to preview environment for Git SHA cbabf64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable SSL Pinning on the mobile apps when you build your own.
Do not merge until this functionality is released.
Related PR's:
mattermost/react-native-network-client#129
mattermost/mattermost-mobile#8055
Ticket Link
https://mattermost.atlassian.net/browse/MM-59055