SSL Pinning support #129
Merged
SSL Pinning support #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
approved these changes
Jul 3, 2024
|
Sure @rahimrahman I can explain at some point in the near future about all this |
cpoile
approved these changes
Jul 10, 2024
esarafianou
reviewed
Jul 19, 2024
enzowritescode
requested changes
Jul 19, 2024
android/src/main/java/com/mattermost/networkclient/NetworkClient.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/mattermost/networkclient/NetworkClient.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/mattermost/networkclient/NetworkClient.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/mattermost/networkclient/NetworkClient.kt
Outdated
Show resolved
Hide resolved
enzowritescode
approved these changes
Jul 20, 2024
enahum
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of some of the requirements by XXXXX we needed to add support for SSL Pinning when building your own app.
The way is being built is a combination of the app and the network-client library, the app will hold the certificate assets while the network-library will use these certs to verify the server trust.
The cert files should have either a
.crtor.cerextension while the name of the file must be the domain name.The reason we support two files extensions per domain is to be able to build the app taking into account server cert rotation and minimizing the amount of app distribution through updates in order to validate the certs.
This SSL Pinning certificates should be included in the app at build time.
Ticket Link
https://mattermost.atlassian.net/browse/MM-59055