-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-58561] Calls: Add stop recording confirmation; update call screen #8007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome @cpoile! Thank you! A couple of minor things I noticed but they aren't blockers:
- The call title and the time are slightly misaligned. The title probably needs to be moved down a bit so that they are in the same line. It is more visible on iOS than on Android.
- The minimize icon needs to be moved to the right to match the spacing on the left and right of the header content. Probably needs to be moved by about 12pts.
- Not directly related to this PR, but the icon on the
Stop recording
menu item should also be red instead of the default grey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@abhijit-singh Can you take a look now? I made some changes: the left and right padding stays at 24 now. When the rec badge pops in, we increase the left and right width (but keep the collapse icon in the same place), which keeps the center title in the same position but reduces its width symmetrically. This way we can keep left/right balance, but maximize the center title size. Let me know what you think? We can go back to the original if you would prefer the time to not change (but then the center title will always be smaller). |
Thanks @cpoile! Looks great visually now! |
…l screen (mattermost#8007)" This reverts commit 53b0110.
Summary
Ticket Link
Checklist
E2E iOS tests for PR
.Device Information
Release Note