-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-57365] Stop recording confirmation modal #760
Conversation
I assume this is by design, so it's more of a question for @abhijit-singh. I don't see any mention of transcriptions, which is a bit inconsistent with the rest of the related messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Nothing blocking, but I noticed the stop button is not strictly following the latest updates on similar "destructive" buttons in terms of hover and active states and related background/text colors.
Thanks! Fixed the background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome @cpoile! Thank you!
For the case where transcription is also enabled, we can have the modal say :
Title: Stop recording and transcription
Body: The call recording and transcription files will be processed and posted in the call thread. Are you sure you want to stop the recording and transcription?
cc @cwarnermm
Thanks @abhijit-singh, updated with the new text. |
Summary
Ticket Link