Add more manifest metadata #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
approved these changes
Jan 26, 2020
manland
approved these changes
Jan 27, 2020
hanzei
added
4: Reviews Complete
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
homepage_urlandsupport_urlto the manifest.support_urlis not jet used in the webapp, but there is no downside of defining it already.I also added an icon for the marketplace.
I've tested the changes locally and can confirm that the link to the
homepage_urlis correctly shown and the icon is shown.Ticket Link
https://mattermost.atlassian.net/browse/MM-21918