Avoid kvset/kvget race on subscriptions update #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding or deleting a subscription, we save the subscriptions via `KVSet`, and previously turned around to fetch those with `KVGet` before broadcasting to the client. On installations with a database replica, the second request might not hit the `master` database, and the update just effected might not be "seen". Skip the `KVGet` and instead just use the information about the updated susbcriptions that we already have in hand when updating the client. Fixes: #342
Codecov ReportBase: 32.00% // Head: 32.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 32.00% 32.45% +0.45%
==========================================
Files 21 21
Lines 3390 3389 -1
==========================================
+ Hits 1085 1100 +15
+ Misses 2196 2182 -14
+ Partials 109 107 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mickmister
approved these changes
Jan 9, 2023
spirosoik
approved these changes
Jan 10, 2023
lieut-data
added
the
4: Reviews Complete
hanzei
added
3: QA Review
|
@DHaussermann The PR is ready for your review |
DHaussermann
approved these changes
Jan 10, 2023
DHaussermann
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When adding or deleting a subscription, we save the subscriptions via
KVSet, and previously turned around to fetch those withKVGetbefore broadcasting to the client. On installations with a database replica, the second request might not hit themasterdatabase, and the update just effected might not be "seen".Skip the
KVGetand instead just use the information about the updated susbcriptions that we already have in hand when updating the client.Ticket Link
Fixes: #342