Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid kvset/kvget race on subscriptions update #348

Merged
merged 2 commits into from
Jan 10, 2023

Commits on Dec 15, 2022

  1. Avoid kvset/kvget race on subscriptions update

    When adding or deleting a subscription, we save the subscriptions via `KVSet`, and previously turned around to fetch those with `KVGet` before broadcasting to the client. On installations with a database replica, the second request might not hit the `master` database, and the update just effected might not be "seen".
    
    Skip the `KVGet` and instead just use the information about the updated susbcriptions that we already have in hand when updating the client.
    
    Fixes: #342
    lieut-data committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c6fabac View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Configuration menu
    Copy the full SHA
    6676300 View commit details
    Browse the repository at this point in the history