Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server responds with 200 even when post fails due to bad JSON. #3

Closed
apophisnow opened this issue Aug 16, 2018 · 2 comments
Closed

Server responds with 200 even when post fails due to bad JSON. #3

apophisnow opened this issue Aug 16, 2018 · 2 comments
Assignees
@hanzei

Comments

@apophisnow
Copy link

If you send a request to the Jira webhook endpoint with correct secret, channel, etc, but bad JSON (for example {"test": "test"}), the server responds with a blank 200 response instead of an error. No message gets posted to Mattermost.
@amyblais
Copy link
Member

Hi @apophisnow! Apologies that this got missed earlier - are you still experiencing trouble with this?

@fireau1
Copy link

fireau1 commented Jan 7, 2019

yes this issue remains. and there is nothing in the logfile either

@hanzei hanzei self-assigned this Jan 7, 2019
This was referenced Jan 8, 2019
Merged
Closed
@levb levb mentioned this issue Sep 30, 2019
Merged
@jfrerich jfrerich mentioned this issue Feb 6, 2020
Closed
@jfrerich jfrerich mentioned this issue Jun 2, 2020
Closed
avas27JTG pushed a commit that referenced this issue Mar 8, 2024
@Kshitij-Katiyar @maisnamrajusingh
@mickmister @Nityanand13 @raghavaggarwal2308
[GH-768]: Fixed Issue /Jira Connect doesn't open mattermost's subpath…
d08f7f7 
… url (#870)

* [MI-2154]:Fixed issue(768) /Jira Connect doesn't open mattermost's subpath url (#3)

* Fixes #768

* Update webapp/src/actions/index.ts

updated the url to use string interpolation syntax.

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* updated with feedback from Michael

* removed the unwanted styles changes

* removed the unwanted styles changes

* removed the unwanted styles changes

* resolved comments

* resolved comments

* plugin now adds the entire url from the config

* connect to cloud with subpath now working

* fixed styling and linting issues

* fixed linting issue

* Update server/user_cloud.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* updated method to call the site url with a sub path

* updated method to call the site url with a sub path

* updated logic based on lev's comments

* added a method in plugin.go that will generate the final path

* updated based on feedback from levb

* added method to generate full path

* fixed conflicts

* updated and tested connect

* Update index.ts

removed whitespace

* Update webpack.config.js

* updated SiteURL handler

* [MI-2154]:fixed lint errors

* [MI-2154]:fixed review fixes

Co-authored-by: Sanjay <sanjaymj@12345>
Co-authored-by: Maisnam Raju Singh <85172229+maisnamrajusingh@users.noreply.github.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: maisnamrajusingh <raju.s@demansol.com>

* [MM-768]:fixed CI error

* Improved code quality (#5)

* Review fixes done

* [MI-2182]: Review fixes done
1. Improved code quality

* [MI:2182]:Review fixes done
1.Improved code quality

* Review fixes done of #870 (#13)

* Review fixes done

* [MI-2182]: Review fixes done
1. Improved code quality

* [MI:2182]:Review fixes done
1.Improved code quality

* [MI-2182]: Review fixes done
1.Improved code quality

* [MI-2182]:Fixed CI errors

* [MM-768]:Fixed review comment

* [MI-2839]: Done the review fixes of a Jira PR #870 (#41)

* [MI-2839]: Done the review fixes of a Jira PR #887

* [MI-2839]: Review fixes done
1.Changed the way to create a full URL path

---------

Co-authored-by: Sanjay <sanjaymj@12345>
Co-authored-by: Maisnam Raju Singh <85172229+maisnamrajusingh@users.noreply.github.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: maisnamrajusingh <raju.s@demansol.com>
Co-authored-by: Nityanand Rai <107465508+Nityanand13@users.noreply.github.com>
Co-authored-by: Nityanand Rai <nityanand.rai@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanzei hanzei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@apophisnow @hanzei @amyblais @fireau1