Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/Jira Connect doesn't open mattermost's subpath url #768

Closed
sphr opened this issue Apr 26, 2021 · 3 comments · Fixed by #870
Closed

/Jira Connect doesn't open mattermost's subpath url #768

sphr opened this issue Apr 26, 2021 · 3 comments · Fixed by #870
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/ReactJS Tech/TypeScript Type/Bug Something isn't working
Milestone
next milestone

Comments

@sphr
Copy link

sphr commented Apr 26, 2021

We have our mattermost installation running in a subpath called /app/ (picked by us), when a user runs the /jira connect command, mattermost opens a new window that does not include /app/ in the url, but instead uses /plugins/jira/ directly.

Please make sure the URI includes the user's subpath as this is a configurable variable plugins need to be aware of.
@sphr sphr changed the title Jira Connect doesn't open mattermost's subpath url /Jira Connect doesn't open mattermost's subpath url Apr 26, 2021
@mickmister mickmister added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/ReactJS Tech/TypeScript Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers labels Apr 26, 2021
@mickmister
Copy link
Contributor

Thanks @sphr, looks like we need to prepend the site url here

mattermost-plugin-jira/webapp/src/actions/index.ts

Line 416 in 9681f1e

const target = '/plugins/' + PluginId + instancePrefix + '/user/connect';

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 30, 2021
@sanjaydemansol
Copy link

@hanzei how do we get that variable? using GetConfig() ?

sanjaydemansol pushed a commit to demansoltech/mattermost-plugin-jira that referenced this issue Jul 16, 2021
Fixes mattermost#768
3b9ee7e
@hanzei
Copy link
Collaborator

hanzei commented Jul 16, 2021

@sanjaydemansol Jep. GetConfig() returns the mattermost config where you find the SiteURL.

@maisnamrajusingh maisnamrajusingh mentioned this issue Jul 20, 2021
Closed
@hanzei hanzei added this to the v3.2.0 milestone Jan 4, 2022
@hanzei hanzei modified the milestones: v3.2.0, v3.3.0 Mar 1, 2022
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-jira that referenced this issue Sep 21, 2022
@Kshitij-Katiyar @maisnamrajusingh @mickmister
[MI-2154]:Fixed issue(768) /Jira Connect doesn't open mattermost's su…
18c94bb 
…bpath url (#3)

* Fixes mattermost#768

* Update webapp/src/actions/index.ts

updated the url to use string interpolation syntax.

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* updated with feedback from Michael

* removed the unwanted styles changes

* removed the unwanted styles changes

* removed the unwanted styles changes

* resolved comments

* resolved comments

* plugin now adds the entire url from the config

* connect to cloud with subpath now working

* fixed styling and linting issues

* fixed linting issue

* Update server/user_cloud.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* updated method to call the site url with a sub path

* updated method to call the site url with a sub path

* updated logic based on lev's comments

* added a method in plugin.go that will generate the final path

* updated based on feedback from levb

* added method to generate full path

* fixed conflicts

* updated and tested connect

* Update index.ts

removed whitespace

* Update webpack.config.js

* updated SiteURL handler

* [MI-2154]:fixed lint errors

* [MI-2154]:fixed review fixes

Co-authored-by: Sanjay <sanjaymj@12345>
Co-authored-by: Maisnam Raju Singh <85172229+maisnamrajusingh@users.noreply.github.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: maisnamrajusingh <raju.s@demansol.com>
@Kshitij-Katiyar Kshitij-Katiyar mentioned this issue Sep 21, 2022
Merged
@hanzei hanzei added Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Hacktoberfest labels Feb 21, 2023
@hanzei hanzei linked a pull request Feb 22, 2023 that will close this issue
[GH-768]: Fixed Issue /Jira Connect doesn't open mattermost's subpath url #870
Merged
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Feb 23, 2023
avas27JTG pushed a commit that referenced this issue Mar 8, 2024
@Kshitij-Katiyar @maisnamrajusingh
@mickmister @Nityanand13 @raghavaggarwal2308
[GH-768]: Fixed Issue /Jira Connect doesn't open mattermost's subpath…
d08f7f7 
… url (#870)

* [MI-2154]:Fixed issue(768) /Jira Connect doesn't open mattermost's subpath url (#3)

* Fixes #768

* Update webapp/src/actions/index.ts

updated the url to use string interpolation syntax.

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* updated with feedback from Michael

* removed the unwanted styles changes

* removed the unwanted styles changes

* removed the unwanted styles changes

* resolved comments

* resolved comments

* plugin now adds the entire url from the config

* connect to cloud with subpath now working

* fixed styling and linting issues

* fixed linting issue

* Update server/user_cloud.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* updated method to call the site url with a sub path

* updated method to call the site url with a sub path

* updated logic based on lev's comments

* added a method in plugin.go that will generate the final path

* updated based on feedback from levb

* added method to generate full path

* fixed conflicts

* updated and tested connect

* Update index.ts

removed whitespace

* Update webpack.config.js

* updated SiteURL handler

* [MI-2154]:fixed lint errors

* [MI-2154]:fixed review fixes

Co-authored-by: Sanjay <sanjaymj@12345>
Co-authored-by: Maisnam Raju Singh <85172229+maisnamrajusingh@users.noreply.github.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: maisnamrajusingh <raju.s@demansol.com>

* [MM-768]:fixed CI error

* Improved code quality (#5)

* Review fixes done

* [MI-2182]: Review fixes done
1. Improved code quality

* [MI:2182]:Review fixes done
1.Improved code quality

* Review fixes done of #870 (#13)

* Review fixes done

* [MI-2182]: Review fixes done
1. Improved code quality

* [MI:2182]:Review fixes done
1.Improved code quality

* [MI-2182]: Review fixes done
1.Improved code quality

* [MI-2182]:Fixed CI errors

* [MM-768]:Fixed review comment

* [MI-2839]: Done the review fixes of a Jira PR #870 (#41)

* [MI-2839]: Done the review fixes of a Jira PR #887

* [MI-2839]: Review fixes done
1.Changed the way to create a full URL path

---------

Co-authored-by: Sanjay <sanjaymj@12345>
Co-authored-by: Maisnam Raju Singh <85172229+maisnamrajusingh@users.noreply.github.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: maisnamrajusingh <raju.s@demansol.com>
Co-authored-by: Nityanand Rai <107465508+Nityanand13@users.noreply.github.com>
Co-authored-by: Nityanand Rai <nityanand.rai@brightscout.com>
Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/ReactJS Tech/TypeScript Type/Bug Something isn't working
Projects
Brightscout Plugin Maintenance
Status: Done
Milestone
next milestone
6 participants
@cpanato @mickmister @sphr @hanzei @maisnamrajusingh @sanjaydemansol