Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-54994] Use local requests instead of HTTP requests in the flow library #1034

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Mar 13, 2024

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 13, 2024
@hanzei hanzei requested a review from mickmister as a code owner March 13, 2024 20:33
@mickmister mickmister added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Mar 14, 2024
@mickmister
Copy link
Contributor

@hanzei Do you think we should defer to release testing for this PR?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 33.35%. Comparing base (d08f7f7) to head (6be57d4).
Report is 2 commits behind head on master.

Files Patch % Lines
server/setup_flow.go 0.00% 16 Missing ⚠️
server/plugin.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
+ Coverage   33.13%   33.35%   +0.22%     
==========================================
  Files          53       53              
  Lines        7983     8001      +18     
==========================================
+ Hits         2645     2669      +24     
+ Misses       5111     5109       -2     
+ Partials      227      223       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister mickmister merged commit 0e46aaa into master Mar 14, 2024
9 checks passed
@mickmister mickmister deleted the MM-54994_flow-post-action-local branch March 14, 2024 06:51
@hanzei hanzei added this to the v4.1.1 milestone Mar 15, 2024
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants