[MM-54994] Use local requests instead of HTTP requests in the flow library #26471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
|
E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts. |
mm-cloud-bot
added
the
release-note
|
I did try writing tests for the change but gave up due to the fact that |
mickmister
approved these changes
Mar 13, 2024
larkox
approved these changes
Mar 14, 2024
|
Can you please test this PR as part of the JIRA v4.1.1 release testing? (https://community.mattermost.com/core/pl/nnrfcy7s6bd7zcngg79c89bzpe) |
AayushChaudhary0001
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Approving this PR on the behalf that the Jira release-candidate 4.1.1 has been already tested.
For more info, please go through this thread:-
https://community.mattermost.com/core/pl/bhgj3s3bhjyrxbjpcjxnt9fs5w
hanzei
added
4: Reviews Complete
jwilander
added
the
kind/refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of a complete round trip via HTTP, the flow library now uses a local request.
Many customers had issues due to firewall configurations, as the MM server could not reach itself via HTTP.
Please note that this PR contains a breaking change for the
flowpackage. I will file follow-up tickets to update the Jira, GitHub and Gitlab plugin.Ticket Link
https://mattermost.atlassian.net/browse/MM-54994
Release Note