-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-21762] Refactor jira issue search #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks @mickmister !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!!
@DHaussermann ready for you to regression-test |
@mickmister there seems to be an issue with this change. For the "Attach to Jira" functionality, searching when the search terms includes spaces no longer seems to return correct results. This appears to be a regression from the behavior on master. I tested with the same data-set. |
@DHaussermann Found the issue. I was encoding the user's string, as well as the query string itself, resulting in double encoding. Your test case works correctly now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @DHaussermann !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
Issue search is now working as expected
- Single word
- Multiple word
- Matches when words are out of order
- Partial matches when numbers are strings "1" matches "1", "10", "12"
- Issue keys can be searched
- Searches summary and description of issues
- etc...
Also looked at Epic search again quickly
LGTM!
Summary
This PR refactors the issue search endpoint to be more flexible, so the epic search can use the same endpoint. This is useful to allow for more help wanted tickets centered around searching for issues.
Ticket Link
https://mattermost.atlassian.net/browse/MM-21762