Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-21762] Refactor jira issue search #442

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Conversation

mickmister
Copy link
Contributor

Summary

This PR refactors the issue search endpoint to be more flexible, so the epic search can use the same endpoint. This is useful to allow for more help wanted tickets centered around searching for issues.

Ticket Link

https://mattermost.atlassian.net/browse/MM-21762

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 14, 2020
@mickmister mickmister changed the title Refactor jira issue search [MM-21762] Refactor jira issue search Jan 14, 2020
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @mickmister !

Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@levb levb removed the 2: Dev Review Requires review by a core committer label Jan 20, 2020
@levb
Copy link
Contributor

levb commented Jan 20, 2020

@DHaussermann ready for you to regression-test

@levb levb added this to the v2.4 milestone Jan 20, 2020
@DHaussermann
Copy link

DHaussermann commented Jan 27, 2020

@mickmister there seems to be an issue with this change. For the "Attach to Jira" functionality, searching when the search terms includes spaces no longer seems to return correct results.
For example, if the title dkh filter test 10 exists I see the record included when searching for "dkh" but when I type "dkh filter" to refine my search I see no results.

This appears to be a regression from the behavior on master. I tested with the same data-set.
Searching with spaces on subscription filters appears to behave normally.

@mickmister
Copy link
Contributor Author

@DHaussermann Found the issue. I was encoding the user's string, as well as the query string itself, resulting in double encoding. Your test case works correctly now.

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @DHaussermann !

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed
Issue search is now working as expected

  • Single word
  • Multiple word
  • Matches when words are out of order
  • Partial matches when numbers are strings "1" matches "1", "10", "12"
  • Issue keys can be searched
  • Searches summary and description of issues
  • etc...
    Also looked at Epic search again quickly
    LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Jan 29, 2020
@mickmister mickmister merged commit b5b54a1 into master Jan 29, 2020
@mickmister mickmister deleted the refactor-jira-issue-search branch January 29, 2020 22:10
@jfrerich jfrerich mentioned this pull request Mar 31, 2020
11 tasks
@jfrerich jfrerich mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants