Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.4.0 #530

Merged
merged 1 commit into from
May 18, 2020
Merged

Bump version to 2.4.0 #530

merged 1 commit into from
May 18, 2020

Conversation

jfrerich
Copy link
Contributor

@jfrerich jfrerich commented Apr 28, 2020

Summary

Bump version to v2.4.0

Proposal to bump version following Release Notes:

Summary

Bump version to v2.4.0

Proposal to bump Feature Version to prep for release with the following Release Notes:

Enhancements

Fixes

@jfrerich jfrerich requested review from levb and hanzei April 28, 2020 13:38
@jfrerich jfrerich added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 28, 2020
@jfrerich jfrerich added this to the v2.4 milestone Apr 28, 2020
@@ -0,0 +1 @@
/Users/jfrerich/dotfiles/mattermost/.projections.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed. That's actually a handy file that makes opening alternative files easy. The most common example is defining test files as alternative files. https://github.com/jfrerich/dotfiles/blob/master/mattermost/.projections.json

@codecov-io
Copy link

Codecov Report

Merging #530 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   33.92%   33.97%   +0.04%     
==========================================
  Files          37       37              
  Lines        4604     4604              
==========================================
+ Hits         1562     1564       +2     
+ Misses       2893     2891       -2     
  Partials      149      149              
Impacted Files Coverage Δ
server/subscribe.go 65.94% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6a9f5...3dea970. Read the comment docs.

Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb requested a review from DHaussermann April 29, 2020 13:06
@levb levb removed the 2: Dev Review Requires review by a core committer label Apr 29, 2020
@levb levb added the 1: PM Review Requires review by a product manager label Apr 29, 2020
@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label May 18, 2020
@jfrerich
Copy link
Contributor Author

@DHaussermann gentle reminder for the review!

@levb
Copy link
Contributor

levb commented May 18, 2020

#546 should be included

@jfrerich jfrerich added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label May 18, 2020
@DHaussermann
Copy link

DHaussermann commented May 18, 2020

Apologies. Seems I did not post here last week. End to end testing for Jira 2.4 was completed. We were just waiting on 1 fix.
Once this change (linked b y @levb) is in master we'll be good.

@jfrerich
Copy link
Contributor Author

@DHaussermann, I just merged #546!

@jfrerich jfrerich removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label May 18, 2020
@DHaussermann
Copy link

DHaussermann commented May 18, 2020

Tested and passed

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels May 18, 2020
@jfrerich jfrerich merged commit fd75216 into master May 18, 2020
@jfrerich jfrerich deleted the bump-version-v2.4.0 branch May 18, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants