Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help text test #446

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Fix help text test #446

merged 1 commit into from
Jan 20, 2020

Conversation

mickmister
Copy link
Contributor

Summary

There was a mishap with a PR being merged without having latest master, causing a false positive in the tests. This is the second time this has happened in the recent past. Maybe we should always force an update with master before merging on plugin repos? @levb

@mickmister mickmister added the 2: Dev Review Requires review by a core committer label Jan 17, 2020
@levb levb added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 20, 2020
@levb levb added this to the v2.4 milestone Jan 20, 2020
@levb levb merged commit 32b3d6b into master Jan 20, 2020
@levb levb deleted the fix-help-text-test branch January 20, 2020 16:09
@jfrerich jfrerich mentioned this pull request Mar 31, 2020
11 tasks
@jfrerich jfrerich mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants