Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When posting a response from the Jira plugin, we get React warnings in the console #466

Merged
merged 1 commit into from
Feb 7, 2020
Merged

When posting a response from the Jira plugin, we get React warnings in the console #466

merged 1 commit into from
Feb 7, 2020

Conversation

AGMETEOR
Copy link
Contributor

@AGMETEOR AGMETEOR commented Feb 6, 2020

Summary

Observed: JavaScript error in the console after creating issue

err

Fixes #173

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 6, 2020
@jfrerich jfrerich requested review from jfrerich and removed request for cpoile February 7, 2020 02:31
jfrerich
jfrerich approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AGMETEOR! I verified the error is no longer seen in the console.

@jfrerich jfrerich merged commit 4de6a53 into mattermost:master Feb 7, 2020
@jfrerich jfrerich mentioned this pull request Mar 31, 2020
Closed
11 tasks
@jfrerich jfrerich mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister approved these changes

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When posting a response from the Jira plugin, we get React warnings in the console
4 participants
@AGMETEOR @mickmister @jfrerich @hanzei