[GH-167] Render JIRA webhook comments as quoted messages #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
|
@promulo Thanks for your PR! Heads up that there are a couple of tests failing: https://app.circleci.com/jobs/github/mattermost/mattermost-plugin-jira/4966 |
|
I see some tests failed, working on it. |
|
Alright, I have updated the failing tests but now I wonder if my change really belongs where it is now or somewhere between the webhook parsing logic and |
jfrerich
approved these changes
Feb 10, 2020
DHaussermann
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Tested and passed.
- Comments now appear with the quote before them
- Tested comment created and comment edit
- Tested on subscription events as well as receiving an at mention that creates a DM from the bot
- Tested on Server and Cloud
LGTM! Thanks @promulo for this enhancement!
Note There is a related issue where text does not show as indented when you use line breaks in a comment. MM-19652 exists in the backlog to address this.
DHaussermann
added
4: Reviews Complete
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes webhook handling for events of type "issue commented" and "issue comment edited" in order to render them as quoted messages in Mattermost.
Thanks for reviewing!
Screenshots
Issue commented
Before
After
Issue comment edited
Before
After
Ticket Link
Fixes #167.