Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a proper webhook URL #474

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Generate a proper webhook URL #474

merged 1 commit into from
Feb 26, 2020

Conversation

AGMETEOR
Copy link
Contributor

Fixes #473

@AGMETEOR AGMETEOR requested a review from cpoile February 12, 2020 16:48
@levb levb requested a review from jfrerich February 12, 2020 17:12
@levb levb added the 2: Dev Review Requires review by a core committer label Feb 12, 2020
cpoile
cpoile approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AGMETEOR!

@jfrerich
Copy link
Contributor

@AGMETEOR, Great catch and thanks for the PR also!

@jfrerich jfrerich added 4: Reviews Complete All reviewers have approved the pull request 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Feb 14, 2020
@jfrerich jfrerich requested review from mickmister and DHaussermann and removed request for mickmister February 14, 2020 03:08
DHaussermann
DHaussermann approved these changes Feb 18, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed.
Extra slash has been removed.
LGTM! Thanks @AGMETEOR

@DHaussermann DHaussermann added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Feb 18, 2020
@jfrerich jfrerich merged commit b5bf3e6 into mattermost:master Feb 26, 2020
@jfrerich jfrerich mentioned this pull request Mar 31, 2020
Closed
11 tasks
@jfrerich jfrerich mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpoile cpoile cpoile approved these changes

@jfrerich jfrerich jfrerich approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate a proper webhook URL
5 participants
@AGMETEOR @jfrerich @cpoile @DHaussermann @levb