Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link #482

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Fix dead link #482

merged 3 commits into from
Mar 16, 2020

Conversation

AGMETEOR
Copy link
Contributor

Fixes #477

Replaced old link with https://github.com/mattermost/mattermost-plugin-jira/blob/master/readme.md

@jfrerich jfrerich added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester AutoMerge Used by Mattermod to merge PR automatically labels Mar 3, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

3 similar comments
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@@ -13,3 +13,6 @@ vendor

# Intellij
.idea/

#VS CODE
.vscode/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Unix-style new line? :)

@levb levb added this to the v2.4 milestone Mar 3, 2020
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @AGMETEOR! LGTM

@jfrerich jfrerich removed the 2: Dev Review Requires review by a core committer label Mar 5, 2020
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Link successfully direct user to current Repo
  • Added an explicit test for this to release testing
    LGTM! Thanks @AGMETEOR

@DHaussermann DHaussermann added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Mar 5, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@hanzei hanzei removed the AutoMerge Used by Mattermod to merge PR automatically label Mar 7, 2020
@jfrerich
Copy link
Contributor

@aaronrothschild - ping for review

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Mar 12, 2020
@jfrerich jfrerich merged commit a466955 into mattermost:master Mar 16, 2020
@jfrerich jfrerich mentioned this pull request Mar 31, 2020
11 tasks
@jfrerich jfrerich mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin config page has dead link to README.md
7 participants