Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm -E audit fix in prep for 2.4 release #521

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

jfrerich
Copy link
Contributor

Summary

The following PR (#512) was originally created to update npm packages but has also broken the build. This is a fresh PR to update off of the latest master build.

The command that has been run is npm -E audit fix which updates security issues.

-E is short for --save-exact

@jfrerich jfrerich requested a review from levb as a code owner April 13, 2020 20:23
@jfrerich
Copy link
Contributor Author

I hated to do this, but the previously mentioned PR #512 wasn't building. I also had run npm-check -E -y which updates dependencies (not security issues). My guess is that we should update dependencies at some point, but it will require some massaging to get the build passing. By updating only the security issues, this build passes.

FYI, this is the last remaining item before cutting v2.4.0.

@levb levb added the 4: Reviews Complete All reviewers have approved the pull request label Apr 14, 2020
@levb levb added this to the v2.4 milestone Apr 14, 2020
@levb levb merged commit e1c2a96 into master Apr 14, 2020
@levb levb deleted the bump-v2.4.0-dependencies-off-latest-master branch April 14, 2020 03:37
@jfrerich jfrerich mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants