[GH-529] No attachment text when error happens while uploading attachment #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorgabucio
changed the title
|
I'm a contributor, hector2 but I changed the Github username 🙄 |
hanzei
added
2: Dev Review
|
/check-cla |
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 33.92% 35.30% +1.38%
==========================================
Files 37 37
Lines 4604 4605 +1
==========================================
+ Hits 1562 1626 +64
+ Misses 2893 2825 -68
- Partials 149 154 +5
Continue to review full report at Codecov.
|
jfrerich
suggested changes
May 5, 2020
jfrerich
approved these changes
May 5, 2020
levb
approved these changes
May 6, 2020
DHaussermann
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Tested and passed
- Tested no permission to attach - no longer see
!! - Tested size exceeded - no longer see
^
No issues found.
Thanks @hectorgabucio for this fix!
DHaussermann
added
4: Reviews Complete
levb
added a commit
that referenced
this pull request
Aug 10, 2020
* Add .npmrc file for save-exact packages (#586) * [GH-529] No attachment text when error happens while uploading attachment (#535) * [GH-527] Fix README TOC anchor linking (#580) * Fixed the merge and the merged test to reflect multi-instance changes * fixed concurrency issues in the test Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: Hector <hectordorito5@gmail.com> Co-authored-by: Jason Frerich <jason.frerich@mattermost.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attachment text not shown if error occurs while adding attachment.
Ticket Link
Fixes #529