Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .npmrc file for save-exact packages #586

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Add .npmrc file for save-exact packages #586

merged 1 commit into from
Jun 15, 2020

Conversation

mickmister
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020 •
edited
Loading

Codecov Report

Merging #586 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   34.02%   34.02%           
=======================================
  Files          37       37           
  Lines        4600     4600           
=======================================
  Hits         1565     1565           
  Misses       2886     2886           
  Partials      149      149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5695c...55c710a. Read the comment docs.

@hanzei hanzei added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer and removed 1: PM Review Requires review by a product manager labels Jun 15, 2020
@jfrerich jfrerich merged commit c6c765a into master Jun 15, 2020
@jfrerich jfrerich deleted the npmrc branch June 15, 2020 15:08
@jfrerich jfrerich removed the 2: Dev Review Requires review by a core committer label Jun 15, 2020
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Jun 16, 2020
levb added a commit that referenced this pull request Aug 10, 2020
@levb @mickmister
@hectorgabucio @jfrerich
Merged from ...-jira (#38)
b4601f9 
* Add .npmrc file for save-exact packages (#586)

* [GH-529] No attachment text when error happens while uploading attachment (#535)

* [GH-527] Fix README TOC anchor linking (#580)

* Fixed the merge and the merged test to reflect multi-instance changes

* fixed concurrency issues in the test

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Hector <hectordorito5@gmail.com>
Co-authored-by: Jason Frerich <jason.frerich@mattermost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mickmister @codecov-commenter @jfrerich @hanzei