Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive CTEs: Stage 2 - add support for sql -> logical plan generation #5

Draft
wants to merge 21 commits into
base: matt/feat/recursive-ctes/config-flag
Choose a base branch
from

Conversation

matthewgapp
Copy link
Owner

@matthewgapp matthewgapp commented Jan 12, 2024

This PR implements sql -> logical plan generation support for Recursive CTEs.

Todos

  • Fill out docs and cleanup. Add more tests.

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/parser branch from f5b9af1 to 8e27b33 Compare January 12, 2024 02:59
@matthewgapp matthewgapp changed the title add config flag for recursive ctes Recursive CTEs: Stage 1 - add support for sql -> logical plan generation Jan 12, 2024
@matthewgapp matthewgapp changed the title Recursive CTEs: Stage 1 - add support for sql -> logical plan generation Recursive CTEs: Stage 2 - add support for sql -> logical plan generation Jan 12, 2024
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/parser branch 2 times, most recently from 98f77ff to 531d541 Compare January 12, 2024 06:08
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/config-flag branch from 5c9fec5 to 91bc4a8 Compare January 14, 2024 00:05
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/parser branch 2 times, most recently from 9615dde to 460561c Compare January 14, 2024 00:40
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/config-flag branch from fa99090 to 91bc4a8 Compare January 15, 2024 18:32
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/parser branch from a3b6463 to 22661af Compare January 15, 2024 21:57
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/config-flag branch from 91bc4a8 to 162e740 Compare January 16, 2024 17:31
* impl cte as work table

* move SharedState to continuance

* impl WorkTableState

wip: readying pr to implement only logical plan

fix sql integration test

wip: add sql test for logical plan

wip: format test assertion
@matthewgapp matthewgapp force-pushed the matt/feat/recursive-ctes/parser branch from 22661af to 8d38c92 Compare January 16, 2024 17:56
simicd and others added 15 commits January 16, 2024 16:02
* Migrate references unit tests to sqllogictest

* Remove unused import
…roundtrip test between expression and proto, (apache#8868)

* add roundtrip test between expression and proto
---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* add config flag for recursive ctes

update docs from script

update slt test for doc change

* restore testing pin
* fix struct

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add test

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* support functions

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

---------

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix datafusion-cli print output

* fmt

* Do not print header if only empty batches, test for same
…expr` to use `transform_down` (apache#8890)

* transform_down

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants