Skip to content

Commit

Permalink
Rollup merge of rust-lang#109595 - GuillaumeGomez:improve-gui-test-au…
Browse files Browse the repository at this point in the history
…to-hide-trait, r=notriddle

Improve "Auto-hide trait implementation documentation" GUI test

Part of rust-lang#66181.

I'll start working on the `include` command for `browser-ui-test` so we can greatly reduce the duplicated code between setting tests.

r? `@notriddle`
  • Loading branch information
matthiaskrgr committed Mar 26, 2023
2 parents 64fdf5e + 16bb719 commit e0cbfb9
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 13 deletions.
13 changes: 0 additions & 13 deletions tests/rustdoc-gui/auto-hide-trait-implementations.goml

This file was deleted.

47 changes: 47 additions & 0 deletions tests/rustdoc-gui/setting-auto-hide-trait-implementations.goml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// Checks that the setting "auto hide trait implementations" is working as expected.

define-function: (
"check-setting",
(storage_value, setting_attribute_value, toggle_attribute_value),
block {
assert-local-storage: {"rustdoc-auto-hide-trait-implementations": |storage_value|}
click: "#settings-menu"
wait-for: "#settings"
assert-property: ("#auto-hide-trait-implementations", {"checked": |setting_attribute_value|})
assert-attribute: ("#trait-implementations-list > details", {"open": |toggle_attribute_value|}, ALL)
}
)

goto: "file://" + |DOC_PATH| + "/test_docs/struct.Foo.html"

// By default, the trait implementations are not collapsed.
call-function: ("check-setting", {
"storage_value": null,
"setting_attribute_value": "false",
"toggle_attribute_value": "",
})

// Now we change its value.
click: "#auto-hide-trait-implementations"
assert-local-storage: {"rustdoc-auto-hide-trait-implementations": "true"}

// We check that the changes were applied as expected.
reload:

call-function: ("check-setting", {
"storage_value": "true",
"setting_attribute_value": "true",
"toggle_attribute_value": null,
})

// And now we re-disable the setting.
click: "#auto-hide-trait-implementations"
assert-local-storage: {"rustdoc-auto-hide-trait-implementations": "false"}

// And we check everything is back the way it was before.
reload:
call-function: ("check-setting", {
"storage_value": "false",
"setting_attribute_value": "false",
"toggle_attribute_value": "",
})

0 comments on commit e0cbfb9

Please sign in to comment.