Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more UI tests for rustdoc #66181

Closed
4 of 5 tasks
GuillaumeGomez opened this issue Nov 7, 2019 · 1 comment
Closed
4 of 5 tasks

Add more UI tests for rustdoc #66181

GuillaumeGomez opened this issue Nov 7, 2019 · 1 comment
Assignees
@GuillaumeGomez
Labels
A-doctests Area: Documentation tests, run by rustdoc A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 7, 2019 •
edited
Loading

It is linked to #60033.

This is the tests we need to add (the list is non-exhaustive):

  • a UI test for each setting
  • click on element in the sidebar hidden by default to be sure it gets fully un-collapsed and scrolled to
  • make tests for each shortcut
  • make tests for source code navigation (through files in the first time should be enough)
  • run all the previous tests in mobile mode
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-doctests Area: Documentation tests, run by rustdoc labels Nov 7, 2019
@GuillaumeGomez GuillaumeGomez self-assigned this Nov 7, 2019
@GuillaumeGomez GuillaumeGomez mentioned this issue Nov 7, 2019
Merged
@JohnTitor JohnTitor added A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. labels May 30, 2020
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 20, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 21, 2023
@matthiaskrgr
Rollup merge of rust-lang#109412 - GuillaumeGomez:add-gui-test, r=not…
ad2ced5 
…riddle

rustdoc: Add GUI test for "Auto-hide item contents for large items" setting

Part of rust-lang#66181.

The `browser-ui-test` version update is because there wasn't `null` check for attributes so I added it (PR is [here](GuillaumeGomez/browser-UI-test#440)).

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 22, 2023
@matthiaskrgr
Rollup merge of rust-lang#109412 - GuillaumeGomez:add-gui-test, r=not…
a7570b0 
…riddle

rustdoc: Add GUI test for "Auto-hide item contents for large items" setting

Part of rust-lang#66181.

The `browser-ui-test` version update is because there wasn't `null` check for attributes so I added it (PR is [here](GuillaumeGomez/browser-UI-test#440)).

r? ``@notriddle``
oli-obk pushed a commit to oli-obk/miri that referenced this issue Mar 23, 2023
@matthiaskrgr
Rollup merge of #109412 - GuillaumeGomez:add-gui-test, r=notriddle
f1165ae 
rustdoc: Add GUI test for "Auto-hide item contents for large items" setting

Part of rust-lang/rust#66181.

The `browser-ui-test` version update is because there wasn't `null` check for attributes so I added it (PR is [here](GuillaumeGomez/browser-UI-test#440)).

r? ``@notriddle``
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 24, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#109570 - GuillaumeGomez:add-gui-test, r=not…
beac95a 
…riddle

Add GUI test for "Auto-hide item methods' documentation" setting

Part of rust-lang#66181.

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 25, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 26, 2023
@matthiaskrgr
Rollup merge of rust-lang#109595 - GuillaumeGomez:improve-gui-test-au…
e0cbfb9 
…to-hide-trait, r=notriddle

Improve "Auto-hide trait implementation documentation" GUI test

Part of rust-lang#66181.

I'll start working on the `include` command for `browser-ui-test` so we can greatly reduce the duplicated code between setting tests.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 26, 2023
@matthiaskrgr
Rollup merge of rust-lang#109595 - GuillaumeGomez:improve-gui-test-au…
2361786 
…to-hide-trait, r=notriddle

Improve "Auto-hide trait implementation documentation" GUI test

Part of rust-lang#66181.

I'll start working on the `include` command for `browser-ui-test` so we can greatly reduce the duplicated code between setting tests.

r? ``@notriddle``
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 26, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Mar 27, 2023
@Dylan-DPC
Rollup merge of rust-lang#109633 - GuillaumeGomez:fix-go-to-only-sett…
7dfd0c2 
…ing, r=notriddle

Fix "Directly go to item in search if there is only one result" setting

Part of rust-lang#66181.

The setting was actually broken, so I fixed it when I added the GUI test.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 27, 2023
@matthiaskrgr
Rollup merge of rust-lang#109633 - GuillaumeGomez:fix-go-to-only-sett…
b39db70 
…ing, r=notriddle

Fix "Directly go to item in search if there is only one result" setting

Part of rust-lang#66181.

The setting was actually broken, so I fixed it when I added the GUI test.

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 31, 2023
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 31, 2023
@GuillaumeGomez
Rollup merge of rust-lang#109818 - GuillaumeGomez:test-collapsed-item…
32842e8 
…, r=notriddle

rustdoc: Add GUI test for jump to collapsed item

Part of rust-lang#66181.

I updated `browser-ui-test` version because I needed to add a new command `property`: GuillaumeGomez/browser-UI-test#452.

r? `@notriddle`
oli-obk pushed a commit to oli-obk/miri that referenced this issue Apr 4, 2023
@matthiaskrgr
Rollup merge of #109570 - GuillaumeGomez:add-gui-test, r=notriddle
b7b0461 
Add GUI test for "Auto-hide item methods' documentation" setting

Part of rust-lang/rust#66181.

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 6, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#110016 - GuillaumeGomez:gui-collapsed-mobil…
273b221 
…e, r=notriddle

Run collapsed GUI test in mobile mode as well

Extending test from rust-lang#109818 to be run on mobile as well.

Part of rust-lang#66181.

r? `@notriddle`
@notriddle notriddle mentioned this issue Apr 7, 2023
Merged
Noratrieb added a commit to Noratrieb/rust that referenced this issue Apr 7, 2023
@Noratrieb
Rollup merge of rust-lang#110037 - notriddle:notriddle/theme-default,…
64443a9 
… r=GuillaumeGomez

rustdoc: add test and bug fix for theme defaults

Part of rust-lang#66181
Noratrieb added a commit to Noratrieb/rust that referenced this issue Apr 7, 2023
@Noratrieb
Rollup merge of rust-lang#110037 - notriddle:notriddle/theme-default,…
b8c372f 
… r=GuillaumeGomez

rustdoc: add test and bug fix for theme defaults

Part of rust-lang#66181
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 7, 2023
Closed
notriddle added a commit to notriddle/rust that referenced this issue Apr 8, 2023
@notriddle
Rollup merge of rust-lang#110037 - notriddle:notriddle/theme-default,…
df163c2 
… r=GuillaumeGomez

rustdoc: add test and bug fix for theme defaults

Part of rust-lang#66181
Noratrieb added a commit to Noratrieb/rust that referenced this issue Apr 8, 2023
@Noratrieb
Rollup merge of rust-lang#110037 - notriddle:notriddle/theme-default,…
3700848 
… r=GuillaumeGomez

rustdoc: add test and bug fix for theme defaults

Part of rust-lang#66181
@GuillaumeGomez
Copy link
Member Author

I think this issue can now be closed. For the mobile tests, I also think we added them where it was necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-doctests Area: Documentation tests, run by rustdoc A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeGomez @JohnTitor