SwiftPM archiving hotfix #185
Conversation
…included, add MavsdkServer library for mavsdk_server.xcframework binaryTarget import to fix archiving issue, update Package.swift usages and naming
| @@ -21,7 +25,7 @@ let package = Package( | |||
| .package(url: "https://github.com/ReactiveX/RxSwift.git", from: "5.0.0"), | |||
| ], | |||
| targets: [ | |||
| .target(name: "MAVSDK-Swift", | |||
| .target(name: "Mavsdk", | |||
There was a problem hiding this comment.
Shouldn't this target now depend on mavsdk_server? Could it be the reason why the build fails in CI?
There was a problem hiding this comment.
I just added it to try it but there may be an issue with binary targets as dependencies in other targets. We may have to create a separate Swift Package just for the binary dependency in another GitHub repo.
There was a problem hiding this comment.
Once a release is tagged on MAVSDK-XCFramework for v0.37.0 this should be ready to merge. It should be tested with the MAVSDK-Swift-Example by adding my fork as a Swift Package dependency referencing branch swiftpm-archiving-hotfix.
…ver as a dependency for Mavsdk library in Package.swift
|
@JonasVautherin The scripts to generate the protos and docs are failing, can you take a look? |
…e, use private @_implementationOnly import mavsdk_server in MavsdkServer
Hotfix in response to an issue with archiving projects using the MAVSDK-Swift SwiftPM dependency remotely. This fix has only been tested with a local SwiftPM import; I will need to test a remote import from this fork.
MAVSDK_Swiftimport toMavsdkand include MavsdkServer.swift.MavsdkServerimport for themavsdk_serverbinary target import to fix archiving issues. NOTE Currently, a Libary in Package.swift can support multiple.targetor one.binaryTarget.